Skip to content

TrailView ground plan GP12.7: roofs: galleries and covered bridges as solid slabs on posts #3348

Open

Description

@timohueser

Status: proposed
Part of #3105 (GP12, the crossing block of #3096). One pull request into ground-plan.
The steps of the block, in build order: GP12.1 #3342, GP12.2a #3343, GP12.2b #3352, GP12.3a #3344, GP12.3b #3353, GP12.4 #3345, GP12.5 #3346, GP12.6 #3347, GP12.7 #3348, GP12.8 #3349.
Read first: #3105 (the thickness rule above all). Design on timosPC:
/media/timo/OSM1/tmp/ground-plan/crossings/CASES.md case 3, drawings/c10-gallery-covered.svg; today's picture
gallery/today/sheets/G01-axen-gallery.jpg. Short names: gp/ = host/obc-ground-plan/src/, tv/ =
builder/web/src/lib/trailview/. Code places verified on ground-plan ea4da43.

Goal

An avalanche gallery is a road under a solid roof slab, with the hill running onto the roof and posts on the valley
side; a covered timber bridge has board walls and a gable roof. Every part has a real thickness: no part reads as a
paper-thin sheet, and the roof does not end in a point that sticks out of the hill.

Depends on / blocks

Design

1. What is wrong today (G01, owner)

  • galleries() (tv/structures/galleries.ts) draws the hill-side wall as one face toward the road (a single
    sheet), a roof with an underside, a top and a valley edge but no end faces and no hill-side face, and pillars as
    closed boxes. Seen from its end, the wall is a sheet with no thickness, and the roof ends as a thin slab that runs
    out of the hill in a point. The owner: the roof and walls read as "super thin sheets instead of walls".
  • The stamp holds the hill over the roof (GALLERY_BACK_M, GALLERY_FILL, GALLERY_REACH_M,
    GALLERY_VALLEY_CUT: tv/terrain/stamp-core.wgsl:167-174, 734-739, 759).

2. The roof sheet (CASES case 3)

  • A gallery way (gallery kind in the tiles, a ground way of storey 0 in the graph: WAYS of
    gp/graph/parts.rs) gets one more sheet over its outline plus edge_band_m, at the clear height of its class
    (today's roof tops at the hill: 6.2 m road, 4.0 m path, 7.5 m rail, tv/terrain/bins.ts:69). The roof sheet ends
    on a straight end line across the way at each end of the gallery's tag, as a deck ends on A.
  • Its shell is a deck's: a slab with edge faces and an underside, closed at its ends.
  • Posts stand on its free outline (the valley side) every post_m, from the floor to the slab.
  • The hill side: the way's cut of storey 0 rises up to the roof (the class rule: a bank, or a wall up to 4.5 m and
    steeper above); the roof's hill edge is not free, the slope meets it. Over the roof the ground is held at the roof
    top where the hill is lower (a floor bound, as GP12.4's cover) and rises from it at the cut slope where the hill is
    higher.
  • A covered bridge (bridge=covered, read today at tv/terrain/bins.ts:398; covered=yes on a bridge way: check
    that the tiles keep the tag, else add it to the bake's kinds): the way is a deck sheet of GP12.3a; its edge feature
    is a board wall of 1.0 m; the roof sheet stands on posts on both free edges and is a gable of two slabs with a
    ridge and eaves (today's COVER_WALL_M 1.0, EAVES_M 2.6, PITCH 0.5, OVERHANG_M 0.4 of
    tv/structures/bridges.ts:18).
Part Thickness
Gallery roof slab 1.2 m at the hill, 0.6 m at the valley edge (today's ROOF of galleries.ts), closed at both ends
Gallery posts 0.6 m square (today's WALL_M of galleries.ts), closed boxes
Gallery wall on the hill side, where the cut stands as a wall a step of the ground body: the hill is behind it; where its top stands free, 0.6 m with a coping
Covered bridge board wall stated in this step before the build (no value in the design), closed
Covered bridge roof slabs stated in this step before the build, closed at the eaves and gables
  • A gallery's ends switch to GP12.2b's end rule: the temporary end kind of GP12.2b goes with this step.

3. Far

The roof as a ribbon with its edge faces to about 2 km, from GP12.6's far forms.

4. What stops on the plan path

galleries() and the covered style of bridges.ts are not drawn with the plan; the gallery terms of the stamp get no
input (nodeStamps, tv/terrain/bins.ts:1048). With that, the COVER bucket of the stamp has no structure input on
the plan path. The default path keeps them until GP19.

Data and bytes

Records: the roof sheet's line (as a deck line). Mesh: about 100 triangles per 20 m (CASES 7.6). Report the bytes.

Invariants

  1. Every roof part has its stated thickness and closes on every visible side; the roof ends on its end lines and
    never stands out of the hill. Check: the shell closure test of GP12.3a; the gallery.
  2. The way under the roof is drawn as without a roof (CASES case 3). Check: the faces and heights of the way equal
    those without the roof sheet, crate test.
  3. No ground lies over the roof's top inside its outline, and none under its underside. Check: crate test.

Decisions already made by the owner that apply

  • "Galleries: yes."
  • The owner's note on G01: the roof and the walls read as super thin sheets; every structure part has a real
    thickness and closed faces.
  • Walls only on road classes; a smooth top and no pattern repeat.

Not in scope

Windows, lamps, the look of timber beyond plain boards; the Kapellbrücke's tower; galleries' ventilation openings.

Proofs and pictures required before review

  • The gallery, all 50 places, before and after; one before | after sheet per place; a verdict table. G01 and K1
    must turn IMPERFECT to GOOD; every other place unchanged.
  • Five more galleries of box B (52 gallery ways, 6.2 km) from the eye and from above, chosen by the implementer from
    the census, and one more covered bridge if box B has one.
  • The owner sees the sheets and gives his OK before the merge.

Cost to measure

Triangles per 20 m of gallery against today's galleries.ts mesh; cell build time over the cells with a gallery;
bytes; frame on walk, valley-drive, luz; WASM bytes, gzip and raw (the block's 15 to 25 kB; stop past 25 kB in
total).

Risks and the stop rule

  • Stop and report if the roof needs a shape of its own beyond the deck's slab and posts, or a repair pass at the hill.
  • Stop and report if any cost reaches twice its base.
  • After two failed review rounds, stop and report.

Requirements: the verification console could not be checked from this PC (no agent token here). The orchestrator sets
the pull request's Requirements: line.

Activity

  1. timohueser commented on Nov 13, 2026

    @timohueser
    OwnerAuthor

    From GP12.3b part A (PR #3470), for GP12.7

    The levels of the way graph (graph::levels) now run in the feature bake (features revision 18), on every zoom-16 cell of each zoom-13 tile with a road way. The zoom-13 tiles carry per road way the tags levels (the states D/B/O/H and the end lines A/P/C, in metres along the stroke), storey and slab (specs/trailview-features.md, Structures). The device reads them with graph::level_tags::read; it does not run graph::levels. The bake uses the rule tables of its own build: a change of a level rule (cover, lift_max_m, open_max_m, the least rooms, the class rows) or of the code of the levels takes a new bake, a new revision and a fixture rebake (make-fixture.py features, about 10 s); the test the_tiles_carry_the_levels_of_each_cell fails until then. A way of a cell margin reads the levels of the cell that owns it, so cells agree by construction. The low zooms carry no level tags.

    For this step: the storey of a deck over a deck is the tag storey, per feature (the highest that a cell gives it).


    Generated by Claude Code

  2. timohueser commented on Nov 14, 2026

    @timohueser
    OwnerAuthor

    GP12.3b part B (#3482) leaves the covered bridges as they are, beside the new decks:

    • Near the eye the storeys draw a covered bridge's deck (with a railing on its free outline), and the old walls,
      posts and roof of structures/bridges.ts draw beside it (MeshBuilder.beside), from the old bridge's heights. This
      step replaces both with the solid roof on posts.

    Generated by Claude Code

  3. timohueser commented on Nov 14, 2026

    @timohueser
    OwnerAuthor

    A note from the fix round of GP12.3b part B (#3482) for covered bridges.

    A covered bridge's deck (bridge=covered) is now dark timber with a light wood railing and, where the old viewer did
    not count its top as paved, a top of planks. Its walls and roof still draw beside the storey (MeshBuilder.beside), as
    before. The storey's railing stands on the deck's band, inside the covered walls: when this step draws the roof as a
    solid slab on posts, it can leave the covered deck without a railing (DeckWay::railing).


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions