Repository navigation
Closed as duplicate
Closed as duplicate
Copy link
Description
GP3 (#3112) landed in ground-plan with PR #3131 (merge 61bfb3b). This issue holds the items that are still open after that PR.
Owner decisions (pictures on the morning page and in #3112 comment 6645427679):
- sr2: a junction guest that is wider than every other arm leaves a square-end tooth. The options are (a) taper the guest to the widest other arm (prototyped as
gp3/v3/tools/guest-taper-try1.patch, together with a check that a point round's arc turns less than half a turn), (b) a land hull for overlapping rounds, (c) accept the corner and add a check for sharp convex corners. - Class A needles: footways overlap the host's edge by 0.16–0.3 m and leave land needles. The options are (a) fold, (b) pave land holes narrower than the least inner radius (this acts as a closing), (c) count them as GP2 data faults and let GP4's sidewalk candidates take these footways.
Open items from the review (#3131 comment 6646966480; the #3112 body has the scenarios):
- A shared seam's far point can test lines that lie out to about 114 m from the window, outside the read box. Reading that far made rural cells up to ×2 slower, so it was taken out.
- Outline rounds depend on the order of the union's rings and on the asymmetry of the
nearfilter. None of the four rules tried kept the fixture counts.
Both items must be fixed before GP7 depends on the seams and the outline rounds.
Smaller items:
- A taper end on a bend turns by about 12° (short features ck and n1).
- Owner decision (2026-11-05): replace the straight taper with a smooth S taper. The edge bends in and out smoothly, its ends meet both edges at the same slope (C1), with the same length and rate. GP2's least sample spacing stays on the curve. Four tries are in PR ground-plan: a junction guest wider than every other arm tapers into them (GP3 follow-ups) #3134; none kept the fixture counts (best: 216 short features, 1 sliver).
- A step of a few millimetres in the carriageway edge where a zero-width shoulder starts (a1, a2).
- 163 short features remain, mostly at junctions: a round's arc that ends in a convex corner.
- Junction-host tapers wait for decision 1.
- The deviation comments for GP4 (TrailView ground plan GP4: faces of sidewalks: kerbs, driveways, zebras, corners, ends and buildings #3099), GP6 (TrailView ground plan GP6: heights: the owner, blend, kerb offset, slope, wall and terrain rules #3113) and GP7 (TrailView ground plan GP7: the mesh, its strip, pieces and floors, and the cell build times #3101) are in the ground-plan GP3: the faces of a cell (core v3) #3131 body. The permission check blocked the agent's comments on those issues, so the owner posts them.
- The bridge WASM budget: with the faces stage the bridge is 515 KiB gzipped against a budget of 272 KiB. GP7 needs a new budget (owner).
The leg split (question 4 of the round; GP3R #3135, request 5, gives it to this issue):
- Split one way into legs where its parts overlap or touch at different heights: a carriageway candidate per leg, the overlap sliced by the medial line, one record line per leg (prototype
scratch/one-model-q4,host/obc-ground-plan/src/faces/legs.rs, records withLEGS=1; evidence on timosPC in/media/timo/OSM1/tmp/ground-plan/one-model/q4w/INDEX.md). It changes the candidates, and the records carry them as they are. - The owner wants to see W with the legs split first. Needed by: GP6's fixture runs with
heights.legs=wall(TrailView ground plan GP6: heights: the owner, blend, kerb offset, slope, wall and terrain rules #3113), GP7's question-4 pictures (TrailView ground plan GP7: the mesh, its strip, pieces and floors, and the cell build times #3101), GP9's question-4 views (TrailView ground plan GP9: ownership in the viewer: floors, the strip, pieces, draw order, range, crack count #3103). - The pull request reports the fixture counts (slivers, short features) and the time per town cell against
ground-plan's head. - Maybe also: a least segment length in bends, if GP6's tight-bend rule does not cover the radial dashes on d-hairpin's outer side (TrailView ground plan GP6: heights: the owner, blend, kerb offset, slope, wall and terrain rules #3113, section 1).
Mode: change #3096
Requirements: none
Generated by Claude Code
Metadata
Metadata
Assignees
Labels
No labels
Activity
timohueser commentedon Nov 5, 2026
Status of the follow-ups (PR #3133, into
ground-plan, not merged)extent_m / 2about each vertex), in the order of their turn and position; a place's round depends on the places withinextent_monly (a place yields to the round of a sharper place withinextent_m / 2that is first). A round's feet lie withinextent_m / 2, so every cell decides the places within 15 m of its window. Carriageways tolines_m= 65.0 m feed the paved outline; reach rowfaces outline. Two-cell test added.ways_m= 114.1 m, reach rowfaces off-line test; per-16-segment carriageway boxes make the test cheap (item 2 alone ×1.015). Two-cell test added./media/timo/OSM1/tmp/ground-plan/gp3/followups/pics/item3/, patchtools/taper-ladder-try.patch.input_monly; a point past it whose round runs through a place out to 35 m is not seen (not in the fixture).Fixture at the head: crashes 0, partition 0, check 2 0 (480 borders), kinks 15, short features 162, fragments 3, slivers 0, jogs 0, bent borders 96 (base: 163 short features, 2 fragments, 98 bent borders). Time ×1.087 against 61bfb3b at load 7 to 9 (item 1 about 6 %).
Generated by Claude Code
timohueser commentedon Nov 5, 2026
Status after the review of PR #3133 (head 796b8bf, not merged)
The reply to the review is #3133 (comment).
len + 2r;lines_m70 m, rowfaces outline140 m.input_monly. No rule fits under 191 m and keeps what the owner sees (rounding the points far enough needs 228 m). Options A to D with their cost are in the reply.Fixture at the head: crashes 0, partition 0, check 2 0 (480 borders), kinks 18, short features 162, fragments 3, slivers 0, jogs 0, bent borders 96.
Generated by Claude Code
timohueser commentedon Nov 5, 2026
Status after PR #3133 (merged, 84b1e4b):
Owner decisions:
gp3/v3/tools/guest-taper-try1.patch). After it, junction hosts get the taper too.Still open: the taper end on a bend (ck, n1), and the a1/a2 shoulder step.
Generated by Claude Code
timohueser commentedon Nov 5, 2026
Owner decision update:
gp3/bands/INDEX.md). It affects only a few height steps (about 5 of the 23 inside faces). It returns with GP4's sidewalk bands, which rebuild the bands anyway. One idea not yet tried: a point's region owns the bands up to its seams.gp3/bands/tools/s-taper-try4.patch, tilestaper/s4-a.png) removes the corners at the taper ends but adds 77 short features and 1 sliver. They come from a hollow near the joint and from edges that wave on bends. Retry with a form that does not follow the varying own offset on bends. Until then, the straight taper stays.Generated by Claude Code
timohueser commentedon Nov 5, 2026
PR #3134 is merged into
ground-plan: the guest taper (sr2 (a)) with the half-turn check, after the adversarial review (comment 6654394639) and green CI. Timing ×1.006 (median per-cell ratio 1.000).Open from the review:
corner_roundrepeatsfacing's arc (DRY).Generated by Claude Code
timohueser commentedon Nov 6, 2026
Owner question at v12 (unequal fillet radii of the road from the right). Cause: a junction's arms end at the next graph point (
faces/mod.rs:863-874stops,faces/points.rs:826,:258). A driveway joins the secondary 3.3 m west on the north side only, but it ends the arm's run on both edges. The SW round (3 m requested: walk bit,min(3, 6)) must have its foot inside the run (round_at,points.rs:432-433), so the ladder shrinks it to 0.82 m; the SE round keeps 5 m. A throwaway build without run stops gives SW 3.00 m. General fix: end an arm's run at the next point only on the side where that point has an arm. Pictures:/media/timo/OSM1/tmp/ground-plan/diag/owner-q/(q2-*).Generated by Claude Code
timohueser commentedon Nov 9, 2026
Cut (owner let the orchestrator decide, 2026-11-09): the S taper. Four tries failed the fixture counts. The straight taper stays as the end shape. The other items of this issue stay open: the a1/a2 step, the run stops at v12, the two wide guests.
Generated by Claude Code
timohueser commentedon Nov 20, 2026
Closed in the backlog cleanup: the open items, together with those of #3166, are in #3743. Fixed: #3133, #3134, #3165. The S taper was cut by the owner on 11-09. #3743 starts with a picture pass on develop, because the junctions changed since (#3521, #3570).
Generated by Claude Code