You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Larger map packs C: the iOS offline reader reads offline block format 3 #3074
Status: approved
Part of #3069. The pack rule, its reasons and the formats are in #3069.
TL;DR
Goal: The iOS offline reader opens bundles of offline block format 3 by the pack rule of #3069, and still opens bundles of format 2. Systems: companion-ios Contracts: none (the specs change in the bake sub-issue) Size: S (1 system)
Plan
companion-ios/OBCCompanion/OfflinePlanner.swiftvalidate: accept offline block format 3, format == 3, zoom == 9 without map_zoom, and keep today's offline block format 2, format == 2, zoom == 9, map_zoom == 11, so that the bundles of today's release still open.
companion-ios/OBCCompanion/OfflineTilesProtocol.swift: for offline block format 2, keep today's min(z, map_zoom) path. For offline block format 3, for zooms from the tile zoom back to the base level, build maps/tiles/<kind>/<k>-<x >> (z-k)>-<y >> (z-k)>.pmtiles and use the first file that exists.
Tests: a bundle of offline block format 3 with a split square serves tiles from the parent and from the child packs; a bundle of format 2 still serves its tiles.
Done when
The suites that obc test affected --base origin/develop selects pass.
Activity