Skip to content

Landmarks: publish Swiss content, re-pin maps and verify hut/tower cards #2026

Closed as duplicate

Description

@timohueser

Remaining landmark content closeout

Category IDs 7–16 are implemented in #2050. Swiss acquisition and two byte-identical offline builds are complete in #2095. #1805 is closed with its source stages complete; do not repeat capture or category implementation.

Remaining:

  • Publish the retained, reviewed Swiss content and re-pin the registered fixture.
  • Rebuild dependent map packages against that content and verify the current format/resource gates.
  • Open actual mountain-hut and observation-tower content in the simulator or device and record the result. Synthetic category tests are not this content check.

Retain provenance and attribution from #2095. Peak View's text-only/Sources/multiple-article board checks stay in #1978; they are separate acceptance. Landmark refresh stays deferred in #1518.

Publication must run serially. This issue review does not publish content or change owner-controlled captures.

Requirements: none

Historical scope and evidence — use the current work above

Current status

The category implementation is complete. PR #2050 merged category IDs 7 through 16 at 9019c769a49fb150721d467f6e7f0fe00ab15a45. The policy, format range, device labels, tests, and public documentation now contain the expanded category table.

The local Swiss preparation is complete in #2095. The independently reviewed evidence records complete acquisition, one retry that resolves all 17 transport failures, and two byte-identical offline builds with 1,453 usable records and 1,330 photos. The per-category table and actual hut/tower sources are in that record. This issue still owns publication and fixture re-pinning, dependent map package rebuilds, and actual-content acceptance for at least one mountain hut and one observation tower. The proposal and census below remain the historical basis for the category change; the source-code work is no longer future work.


The landmark policy keeps seven groups. A census of the Swiss OSM extract (every object with a wikidata tag, classed through Wikidata the way Policy::category does) shows that nine more groups add records with a photo and an article, and huts alone add 15 % to the Swiss set. The owner reviewed three random cards per group and wants all of them.

Groups to add

Each group is one entry in host/obc-pack/src/landmarks/policy.json and one name in CATEGORIES in policy.rs. Roots are Wikidata classes; membership is P31/P279* as today.

Group Roots New Swiss records with photo + article
Mountain huts Q182676 mountain hut, Q339969 Alpine club hut 226
Observation towers Q1440300 observation tower 39
Covered bridges, viaducts and aqueducts Q1825472 covered bridge, Q181348 viaduct, Q12570 suspension bridge, Q474 aqueduct, Q18870689 aqueduct bridge 43
Dams Q12323 dam 41
Industrial heritage Q820477 mine, Q1506469 show mine, Q10832530 ironworks, Q59772 lime kiln, Q185187 watermill, Q38720 windmill, Q40551 salt mine, Q1179791 glassworks 12
Pilgrimage churches and hermitages Q10631691 Catholic pilgrimage church, Q20064854 pilgrimage church, Q56750657 hermitage church 7
Lighthouses Q39715 lighthouse 1
Boundary oddities Q316655 tripoint, Q921099 boundary marker, Q590232 geographical center, Q55818 impact crater 5
Ghost towns Q74047 ghost town, Q350895 abandoned village 0
Hot and mineral springs Q177380 hot spring, Q1365924 mineral spring 0

Not wanted: Q12280 bridge in general (287 records, mostly road bridges), Q108325 chapel (119, weak), Q361665 summit cross (pulls in peaks, which Peak View owns), Q91122 bunker (already under the fortification root).

Industrial heritage needs the exclusion roots Q1662011 industrial building, Q259209 industrial archaeology and Q56284712 industrial archaeology site removed from exclude_roots; they drop ten of the nineteen Swiss candidates. An exclusion still wins over any include, so nothing else changes.

What the change touches

  • policy.json and CATEGORIES: the category byte becomes 1..16. Update the range check in firmware/obc-formats/src/obcm/landmarks.rs and the record table in specs/OBCM_Spec.md §9.
  • kind() in firmware/obc-app/src/screen/landmarks.rs and the strings behind it, one label per new group in every UI language.
  • The policy digest changes, so the Swiss capture must run again into a new directory (fixtures/sources/ride-assistant/CAPTURE.md), the content recompiled, and assistant-switzerland-content plus the sim packages that embed it re-pinned. Expect roughly 380 more Swiss records; check the landmark section against the resource baseline.
  • obc suites check and obc prose --check after the edits.

Verification

obc test -p obc-pack -p obc-bake -p obc-formats -p obc-app, then a device or sim session that opens a hut card and a tower card.

Requirements: none known; suggest one with obc req suggest --check if the landmark plan cites category names.

Activity

  1. added
    enhancementNew feature or request
    firmwareOn-device firmware / board bring-up
    area:packerAffects the obc-pack map packer
    area:appAffects the obc-app area
    on Sep 22, 2026
  2. timohueser commented on Sep 22, 2026

    @timohueser
    OwnerAuthor

    Category support is split into #2049. The current six active IDs stay unchanged; ten additions use IDs 7 through 16. The seventh current policy group is excluded Glaciers, so it has no category byte. The full table, including ghost towns and hot/mineral springs, is the implementation scope. This parent retains the fresh Swiss capture, fixture publication/re-pinning, dependent map package rebuilds, and hut/tower visual acceptance. None of those evidence steps is claimed by the source-only child.

  3. timohueser commented on Sep 22, 2026

    @timohueser
    OwnerAuthor

    Completed in #2050 (merge 9019c769a49fb150721d467f6e7f0fe00ab15a45). One independent Sol review found a spring-label error; the correction received a delta-only approval. All CI checks pass on reviewed head 836741424a21ffbaf20383c14482df752aa42981. Focused app, packer, and codec tests, clippy, suite/prose/docs checks, and one landmark frame comparison pass. Public documentation is a separate commit. #2026 retains fresh capture, fixture publication, map rebuilds, and actual-content hut/tower visual acceptance.

  4. timohueser commented on Sep 22, 2026

    @timohueser
    OwnerAuthor

    The local capture and reproducible content preparation are now bounded in #2095. This work runs without hardware or publication. A Sol agent uses a fresh directory with the merged category policy; a separate reviewer checks completeness, provenance, hashes, and usable counts. Fixture publication, re-pinning, map rebuilds, and actual-content visual acceptance remain here.

  5. changed the title [-]Landmarks: add huts, towers, bridges, dams, industrial heritage, pilgrimage churches, lighthouses and boundary oddities[/-] [+]Landmarks: publish Swiss content, re-pin maps and verify hut/tower cards[/+] on Oct 4, 2026
  6. timohueser commented on Nov 4, 2026

    @timohueser
    OwnerAuthor

    This issue is closed, because obc data v2 replaced the publication path it planned for: #2701 reads wiki shards, and #2901 removed the per-request capture.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:appAffects the obc-app areaarea:packerAffects the obc-pack map packerenhancementNew feature or requestfirmwareOn-device firmware / board bring-up

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions