fix(security): bump pnpm override floor for undici + markdown-it (TIM-29)#155
Conversation
Resolve all 9 advisories from TIM-27 dependency audit. The existing overrides' lower bounds sat inside the vulnerable window, so the lockfile resolved to undici 8.0.2 (vulnerable, 8.0.0 < 8.5.0) and markdown-it 14.1.1 (<=14.1.1). Bumping the floors forces the lockfile to pull in patched releases without requiring version-bumps in @vscode/vsce or other dependents. Overrides changed: undici: '>=7.24.0' -> '>=8.5.0' markdown-it: '>=14.1.1' -> '>=14.2.0' Result: pnpm audit --audit-level=high exits 0 (matches the existing CI gate on pull-request.yml and release.yml). pnpm audit at moderate and low levels also clean. Existing [[IgnoredVulns]] entries in osv-scanner.toml are unchanged. No new pnpm outdated drift. Refs: TIM-29 (this PR), TIM-27 (audit report).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughTwo dependency override version constraints in ChangesDependency Override Bumps
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
No React Doctor issues found. 🎉 Reviewed by React Doctor for commit |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
=======================================
Coverage 94.13% 94.13%
=======================================
Files 10 10
Lines 290 290
Branches 105 105
=======================================
Hits 273 273
Misses 1 1
Partials 16 16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
🎉 This PR is included in version 1.2.47 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
Closes the 9 advisories surfaced by the TIM-27 dependency audit by raising the pnpm-workspace
undiciandmarkdown-itoverride floors above the vulnerable version range.The previous floors sat inside the vulnerable window:
This PR raises them to:
pnpm install --lockfile-onlythen re-resolves the affected transitives without touching any direct dependency versions inpackage.json.Resolves
@vscode/vsce > cheerio > undici@vscode/vsce > markdown-itFull audit: see TIM-27.
Verification
pnpm audit --audit-level=high→ 0 findings (matches the existing CI gate in.github/workflows/pull-request.ymlandrelease.yml)pnpm audit --audit-level=moderate→ 0 findingspnpm audit --audit-level=low→ 0 findings[[IgnoredVulns]]inosv-scanner.tomlunchanged (GHSA-2g4f-4pwh-qvx6 onajv, GHSA-3ppc-4f35-3m26 onminimatch)pnpm outdateddrift — this is a lockfile-only installundici,markdown-it, the transitivelinkify-it5.0.0 → 5.0.1 bump, and dedup of the now-unusedsupports-color@8.1.1peer entriesOut of scope (tracked separately)
@vscode/vsce3.7.1 → 3.9.2 bump — skipped from this PR. The override-floor fix already closes all 9 advisories; bundling a non-security vsce bump would muddy the audit trail and add unrelated churn. Trivial to land in a follow-up.--audit-level=moderate(TIM-27 Actionable chore(deps): update actions/cache action to v5 #4) — separate PR for independent rollback.osv-scannerCI wiring (TIM-27 Actionable chore(deps): update actions/checkout action to v6 #5) — separate PR.@types/vscode1.80 → 1.125,@types/node24 → 26,vite7 → 8,typescript5 → 6,webpack-cli6 → 7,@vitejs/plugin-react5 → 6,@vscode/test-electron2 → 3) — TIM-27 Actionable chore(deps): update node.js to v24.13.1 #3, separate cycle.Risk
Build-time only —
@vscode/vsceis loaded exclusively bypnpm run package/pnpm run publishand does not ship in the published.vsix. The vulnerable code never reaches the extension host or webview. Patched undici/markdown-it versions are drop-in from the override scope; the only behavioural change is the markdown-it smartquotes performance fix (thetypographer: truequadratic-time issue).Refs: TIM-29, TIM-27.
Summary by CodeRabbit
markdown-itandundici.