Repository navigation
Conversation
Keep one door/container binding per local reference and update reassigned server IDs. Notify clients before server objects are retired, preserve entity generation bits, and clear object bindings on disconnect. Add regression coverage for client bindings, message encoding, and server cell retirement. Quest progression, scenes, and dialogue are unchanged.
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clients can retain stale object replication bindings after the server retires a cell's objects or a connection ends. This change keeps a single binding per local door/container reference, updates reassigned server IDs, and clears object bindings on disconnect.
The server broadcasts
NotifyRemoveObjectsbefore destroying retired entities. Clients remove matching bindings using the full server entity ID, including generation bits. This removes replication state without deleting the underlying Skyrim references.Includes regression tests for client binding assignment/removal, message serialization and server cell retirement. Quest progression, scenes and dialogue are outside this change.
Validation
SkyrimTogetherClient,SkyrimTogetherServerandSkyrimServerRunneron the object-only branch with xmake 3.1.0 and MSVC 14.51.TPTests: 63 assertions passed in 9 cases.TPServerTests: 28 assertions passed in 5 cases.MemoryLayout.cpp:35: this toolset rejects the existingconstinitinitializer containingreinterpret_cast. The separate compiler compatibility fix is excluded here.Client and server must use matching builds because this adds a server message. The existing current-cell retention policy is preserved; tracking all loaded exterior cells and persistent container state are not addressed here.
Separates the object lifecycle changes previously included in #890.