Repository navigation
Conversation
Raise logging level and fix logs of quest progression. Previously, multi-execution of quest stage entry was suppressed. But multi quest starts weren't. This is a problem when a quest start has side effects that advance quest stage; as the party members started their quests, the stage-rewind would reflect back to the leader, allowing quest stage side effects to happen again. Also added fix to debugger to force setStage. This is needed so leader can set the stage to the stage they are at, and not have it suppressed so it is sent to party. Regularized quest logging so you can import into a spreadsheet, break fields on colon and comma (:,)
081ce9a to
bcc5ae9
Compare
|
Closing, this is about to be replaced with a far more complete PR. |
|
Reopening. This is the most recent version of quest stage multiple-trigger suppression (such as for The Way Of The Voice) that predates the full deduplication logic that follows it (but I was optimistic about how close to completion it was). This one is safe to merge while still polishing its successor. |
|
Hey @rfortier, this one conflicts with current
Your commits still have you as the author and keep your original message (I only added a short rebase note at the end). When resolving the conflicts I kept the #909 early-return and left the server quest logs at There's one tiny optional commit on top. In I haven't compiled this or tested it with 2 clients. Not a competing PR, it's just there if it saves you some time. |
An update to PR #805 that fixes some additional cases.
Raise logging level and fix logs of quest progression to enable tracking this down.
Previously, multi-execution of quest stage entry was suppressed. But multi quest starts weren't. This is a problem when a quest start has side effects that advance quest stage; as the party members started their quests, the stage-rewind would reflect back to the leader, allowing quest stage side effects to happen again.
Also added fix to debugger to force setStage. This is needed so leader can set the stage to the stage they are at, and not have it suppressed so it is sent to party.
Regularized quest logging so you can import into a spreadsheet, break fields on colon and comma (:,)