Repository navigation
fix(config): deprecate unused profile limits - #498
Merged
EyJunge1 merged 1 commit intoNov 6, 2026
Merged
Conversation
Stop advertising legacy no-op settings in generated and example config, retain backward-compatible parsing, and document the live injection limits. Add regression coverage for templates, legacy files and profile rendering. Fixes tickernelz#492
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #492.
The generated configuration and example advertise profile display limits that have no consumers, so changing them has no effect. Mark
maxProfileItemsanduserProfileDisplayPreferences/Patterns/Workflowsas deprecated in the config types and returned config, and remove the inactive options from generated/example configuration.Existing configuration files still load and retain their legacy values without being rewritten. The README documents the live
userProfileInjectPreferences,userProfileInjectPatterns, anduserProfileInjectWorkflowscontrols and clarifies that they limit LLM context injection rather than web UI display.Test plan
mainbase and absence of a duplicate PR; the cloud test suite was not rerun locally.Checklist
main.bun testpasses (cloud verification above).bun run typecheckpasses (cloud verification).bun run checkpasses (cloud verification).