Skip to content

fix(config): deprecate unused profile limits - #498

Merged
EyJunge1 merged 1 commit into
tickernelz:mainfrom
Phototonic:fix/deprecate-unused-profile-config-492
Nov 6, 2026
Merged

EyJunge1 merged 1 commit into
tickernelz:mainfrom
Phototonic:fix/deprecate-unused-profile-config-492

Conversation

@Phototonic

Copy link
Copy Markdown
Contributor

Summary

Closes #492.

The generated configuration and example advertise profile display limits that have no consumers, so changing them has no effect. Mark maxProfileItems and userProfileDisplayPreferences / Patterns / Workflows as deprecated in the config types and returned config, and remove the inactive options from generated/example configuration.

Existing configuration files still load and retain their legacy values without being rewritten. The README documents the live userProfileInjectPreferences, userProfileInjectPatterns, and userProfileInjectWorkflows controls and clarifies that they limit LLM context injection rather than web UI display.

Test plan

  • Regression tests cover fresh generated/example configuration, unchanged legacy files and values, injection defaults, and the live injection limits taking effect independently of legacy settings.
  • Cloud verification: full suite passed with 1,166 tests passed, 4 platform-specific skips and no failures.
  • Cloud formatting, lint, TypeScript, package build and documentation checks passed. Documentation checks reported one existing warning.
  • Local publication review confirmed the exact tested commit, four-file scope, current main base and absence of a duplicate PR; the cloud test suite was not rerun locally.
  • No runtime profile-selection or UI behavior changes are intended.

Checklist

  • Branch is based on main.
  • bun test passes (cloud verification above).
  • bun run typecheck passes (cloud verification).
  • bun run check passes (cloud verification).
  • Docs / README updated.

Stop advertising legacy no-op settings in generated and example config,
retain backward-compatible parsing, and document the live injection limits.
Add regression coverage for templates, legacy files and profile rendering.

Fixes tickernelz#492
@EyJunge1
EyJunge1 merged commit 4a00809 into tickernelz:main Nov 6, 2026
9 checks passed
@EyJunge1 EyJunge1 mentioned this pull request Nov 6, 2026
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Config: four dead keys are still advertised in the generated template (maxProfileItems, userProfileDisplay*)

2 participants