[codex] Preserve mobile item order - #1002
Open
nexiumbiz-debug wants to merge 1 commit into
Open
nexiumbiz-debug wants to merge 1 commit into
nexiumbiz-debug wants to merge 1 commit into
Conversation
legrottagliegionata
pushed a commit
to legrottagliegionata/angular-gridster2-plus
that referenced
this pull request
Sep 13, 2026
tiberiuzuld#1002) The mobile layout is now a flex column and each item gets an order derived from its grid row and column, so stacked items no longer follow the DOM order. Compared to the upstream patch, mobile items also get flex-shrink: 0. gridster-item is a scroll container (overflow: hidden), so without it the column squashed every item to fit the grid height: checked in the demo at 375px, 174px items shrank to 68px. Fixes upstream tiberiuzuld#924. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
orderfrom its desktop grid row/column positionFixes #924.
Root cause
Mobile mode clears the absolute grid position and makes items relative, so the visible order falls back to dashboard array / DOM order. That can differ from the row/column order users see on desktop.
Validation
npm run test-lib -- --watch=falsenpm run build-libnpx eslint projects/angular-gridster2/src/lib/gridsterRenderer.ts projects/angular-gridster2/src/lib/tests/gridsterRenderer.spec.tsgit diff --check(only the repo's LF/CRLF warning)