Conversation
- offer a checkbox per data group in Settings -> Preferences -> Export My Data, so a subset can be shared without handing over chat history - keep every group checked by default and call exportUserData with no options in that case, so a full backup takes the identical code path - omit absent keys from a partial envelope rather than writing empty arrays; UserDataExport['tables'] is now Partial to say so in the type, because an empty array would claim the user has no chats - assert the grouping invariants in tests: credential tables never leave their parent, and every exportable table belongs to exactly one group (includedTables is schema-derived, so a new table would otherwise join exports and silently belong to no group)
Semgrep Security ScanNo security issues found. |
The group checkboxes were raw <input type="checkbox">, which renders and labels correctly but bypasses the design system's styling and focus treatment and would look out of place against the rest of the settings page. Swapped to the `Checkbox` primitive from src/components/ui/checkbox.tsx, matching how tasks and the debug-transcript dialog use it. Behaviour is unchanged; `onChange` becomes `onCheckedChange`.
|
Preview environment deployed 🚀
Stack: Auto-destroys on PR close/merge. Login via the bundled Keycloak realm — |
PR Metrics
Updated Mon, 14 Sep 2026 01:14:39 GMT · run #3019 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Settings → Preferences → Export My Data now offers a checkbox per data group — chats/projects/prompts, MCP connections, skills and agents, models and providers, tasks and automations, preferences.
Everything is checked by default, so the plain action produces the same whole-account backup as before:
exportUserDatais called with no options in that case, taking the identical code path rather than a filtered equivalent.Why
Sharing a subset. A team standing up the same MCP servers and skills wants to hand round those two groups, not a copy of everyone's chat history.
mcp_secrets,models_secretsandagents_secretsare local-only and never upload, so a shared bundle's credentials reach only the importing device — the recipient can substitute their own.Notes
Object.entries(fileTables)), and its own docs say omitted tables had zero rows, so a partial envelope restores cleanly on current and older builds.UserDataExport['tables']becamePartial<Record<…>>to say so in the type. An empty array would claim the user has no chats; a missing key says chats were not asked for, and only one of those is safe for a restore to act on.mcp_secrets/mcp_servers,models_secrets/models,agents_secrets/agents), and every exportable table belongs to exactly one group. That second one matters becauseincludedTablesis derived from the PowerSync schema, so a new table there joins exports automatically and would otherwise silently belong to no group and vanish from selective exports.trather than at module scope, so they follow a language change.Testing
src/dalandsrc/settingstsc, lint and prettier clean