Skip to content

Make showcase launch independent of shell setup - #94

Merged
thunderballfists merged 2 commits into
mainfrom
feat/dependable-showcase-launch
Oct 1, 2026
Merged

thunderballfists merged 2 commits into
mainfrom
feat/dependable-showcase-launch

Conversation

@thunderballfists

@thunderballfists thunderballfists commented Oct 1, 2026 •

Copy link
Copy Markdown
Owner

Setup instructions relied on a globally available textui command, so the showcase failed when the project was installed in a different environment. Add an executable ./showcase checkout launcher that installs the locked project with isolated Poetry 2.4.3 on Python 3.12 and runs python -m textui.

The launcher resolves its own checkout path, ignores activated environments and stale checkout .venv directories, stops on installation failure, and preserves the application's exit status. README and example instructions use the same environment policy; the source distribution includes the launcher and lockfile. This delivers roadmap unit 1A.

Validation:

  • 436 headless tests passed, including five launcher subprocess regressions.
  • Poetry lock validation and wheel/source builds passed.
  • Pyflakes, shell syntax and Git whitespace checks passed; all six local visual checks passed.
  • Source archive contains the executable launcher, lockfile and showcase; the library wheel remains unchanged in scope.
  • Real terminal launch from a fresh clone, called by absolute path from /tmp, passed and Ctrl+Q exited with status 0. Confirmed Python 3.12 and the fresh clone's installed module were used while a stale checkout .venv and unrelated active-environment settings were ignored. Repeated after deliberately saving a Python 3.14 selection; the launcher switched back to 3.12 and Ctrl+Q again exited cleanly.

Independent review found and verified the saved-interpreter fix: explicit Python 3.12 selection precedes installation. GitHub review feedback about stale .venv/bin/python visual commands was fixed, verified and resolved. Final CI and feedback are checked before merge.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a9cf50c27b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread README.md
@thunderballfists
thunderballfists merged commit e5dfc23 into main Oct 1, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant