Sort a data-table column once per heading click - #90
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 10721c3744
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking a data-table column heading delivers
HeaderSelectedtwice, so the ascending/descending toggle always ends on descending and a table can never be sorted ascending by clicking.Measured on current
main(f8e472c) with real pointer clicks on the second heading of a small table:With this change:
Cause. Textual calls the
_on_*handler of every class in the MRO.SeededDataTable._on_clickand_on_mouse_movealso calledsuper(), which runsDataTable's own handler a second time.Fix. Neither handler calls
super()any more._on_clickonly has to swallow the click that ends a resize press, and does that withevent.prevent_default(), which is what keepsDataTable's handler from running for it. The resize-hover update in_on_mouse_move(from #87) is kept.Tests (both use real Pilot clicks and both fail on
mainwithout the change):HeaderSelected, and repeated clicks toggle ascending, descending, ascending;This was found by an application's test suite, which sorts tables by heading and fails against
main; it passes against this branch.Validation:
pyflakes textui: cleanpython:3.12-slimcontainer with Textual 8.2.8: 6 passed (no snapshot changes)