Focus declared controls when revealed - #88
Merged
Merged
Conversation
thunderballfists
force-pushed
the
fix/revealed-autofocus
branch
from
September 30, 2026 18:35
82d1156 to
0095d07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #66.
Controls marked
autofocus="true"now receive focus when a hidden control or ancestor is displayed after startup. Focus waits for layout and applies only to visible, enabled controls on the active screen. Existing startup, modal, and tab behavior remains covered; anonymous modal autofocus registrations are released on dismissal.Regression tests exercise a runtime account list through initial hiding, repeated reveals, and keyboard selection, plus disabled controls, background modal protection, and anonymous modal cleanup. Docs describe the reveal behavior and current accent background focus cue.
Validation: Python 3.12 suite — 370 passed; visual suite — 6 passed; Pyflakes, build, lockfile, and diff checks passed. Independent review found no defects and confirmed dismissed anonymous controls were garbage-collected across repeated modal cycles.