Bump version to 2.14.0 (spec v159) - #1114
Merged
Merged
Conversation
Two GNU-only constructs made the target unusable on a BSD userland, and only one of them failed loudly. sed -i is spelled differently: BSD requires an argument, GNU must not have one. Detected once from uname and used through $(SED_I). The worse one was \+ in the spec_version regex, which is a GNU basic-regex extension. BSD sed matches nothing rather than erroring, so current_spec_version came back empty, $(( + 1)) evaluated to 1, and the target would have committed "Bump version to X (spec v1)" while leaving runtime/src/lib.rs untouched. Replaced with [0-9][0-9]*, which both accept. Verified on macOS: the regex now returns 158 where it previously returned nothing, and this release's bump correctly reported 158 -> 159.
The bridge lint job started failing with no change to this repo or the workflow: staticcheck could not read the export data for internal/byteorder, internal/cpu and internal/goarch -- stdlib packages that do not exist in the Go 1.21 the job pins. The pin was not binding. dominikh/staticcheck-action installs Go itself unless told otherwise, and with GOTOOLCHAIN=auto that resolves to the newest release. Comparing the runs: July used go1.26.5 at the staticcheck step and passed, today used go1.27.0 and failed. Same runner image, same go-version spec, same staticcheck v0.7.0 -- only the auto-selected toolchain moved. 020_lint_and_test_go_client.yaml already sets install-go: false and passed today on the same commit range. Matching it here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release bump following #1113.
2.13.0 → 2.14.0,spec_version 158 → 159.The spec bump is required: #1113 adds
migrate_node_contractat call index 22, and 158 is already running on devnet.Also here:
make version-bumpnow works on macOSThis release was produced with the fix in place — the run reported
158 → 159correctly, which is the behaviour the second bug would have broken.