Skip to content

FirstPersonControls: Restore R/F shortcuts and unify example look speed. (#34485) #2413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Methuselah96 merged 3 commits into from
Sep 7, 2026
Merged

FirstPersonControls: Restore R/F shortcuts and unify example look speed. (#34485) #2413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68ebfb8
Update three.js
Methuselah96 Sep 7, 2026
24f75a9
Add examples
Methuselah96 Sep 7, 2026
713ca06
Update patch and delete examples
Methuselah96 Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions examples-testing/changes.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1995,7 +1995,7 @@ index 7baaa88a0..e133c2cd2 100644
const wall = new THREE.Mesh(wallGeometry, wallMaterial);
wall.position.set(0, 0.5, -0.5);
diff --git a/examples-testing/examples/webaudio_sandbox.ts b/examples-testing/examples/webaudio_sandbox.ts
index 34afca985..93e033027 100644
index 7e3e91d1e..a98bf93e2 100644
--- a/examples-testing/examples/webaudio_sandbox.ts
+++ b/examples-testing/examples/webaudio_sandbox.ts
@@ -4,20 +4,24 @@ import { GUI } from 'three/addons/libs/lil-gui.module.min.js';
Expand Down Expand Up @@ -4413,7 +4413,7 @@ index 8636812f7..90e2b7b06 100644
});
folderGeometry
diff --git a/examples-testing/examples/webgl_geometry_minecraft.ts b/examples-testing/examples/webgl_geometry_minecraft.ts
index 220156552..32f4cb688 100644
index 552f08a77..b2415780c 100644
--- a/examples-testing/examples/webgl_geometry_minecraft.ts
+++ b/examples-testing/examples/webgl_geometry_minecraft.ts
@@ -6,9 +6,9 @@ import { FirstPersonControls } from 'three/addons/controls/FirstPersonControls.j
Expand Down Expand Up @@ -4685,7 +4685,7 @@ index 2516d660c..0d7d5628f 100644
init();
render();
diff --git a/examples-testing/examples/webgl_geometry_terrain.ts b/examples-testing/examples/webgl_geometry_terrain.ts
index 55b4aa474..2ed4b9f6c 100644
index 5943ac411..c3bd5abab 100644
--- a/examples-testing/examples/webgl_geometry_terrain.ts
+++ b/examples-testing/examples/webgl_geometry_terrain.ts
@@ -5,9 +5,9 @@ import Stats from 'three/addons/libs/stats.module.js';
Expand Down Expand Up @@ -6515,7 +6515,7 @@ index e15a909c3..c3575ef2d 100644

if (probesLeft) {
diff --git a/examples-testing/examples/webgl_lightprobes_sponza.ts b/examples-testing/examples/webgl_lightprobes_sponza.ts
index a9787171d..c9d833582 100644
index daaf3a133..d68973331 100644
--- a/examples-testing/examples/webgl_lightprobes_sponza.ts
+++ b/examples-testing/examples/webgl_lightprobes_sponza.ts
@@ -12,12 +12,16 @@ const MODEL_INDEX_URL =
Expand Down Expand Up @@ -6543,7 +6543,7 @@ index a9787171d..c9d833582 100644
const _size = new THREE.Vector3();
@@ -57,7 +61,7 @@ async function init() {
controls.movementSpeed = 2.0;
controls.lookSpeed = 0.16;
controls.lookSpeed = 0.2;

- const progressBar = document.getElementById('progressBar');
+ const progressBar = document.getElementById('progressBar') as HTMLProgressElement;
Expand Down Expand Up @@ -6831,7 +6831,7 @@ index be8dfd69d..c2b109f2f 100644
.to(
{
diff --git a/examples-testing/examples/webgl_lights_sunlight.ts b/examples-testing/examples/webgl_lights_sunlight.ts
index 2056816a4..bc4ca0f12 100644
index f04b58cda..c00da5e4b 100644
--- a/examples-testing/examples/webgl_lights_sunlight.ts
+++ b/examples-testing/examples/webgl_lights_sunlight.ts
@@ -5,7 +5,16 @@ import { FirstPersonControls } from 'three/addons/controls/FirstPersonControls.j
Expand Down Expand Up @@ -12662,7 +12662,7 @@ index de5426883..6d750ce4b 100644
'\t\t\t\tfloat depth = texture2D( shadowMap, shadowCoord.xy ).r;',
);
diff --git a/examples-testing/examples/webgl_shadowmap_performance.ts b/examples-testing/examples/webgl_shadowmap_performance.ts
index 57fbfbf76..f9716a8ea 100644
index 5cb6b80ce..dec587016 100644
--- a/examples-testing/examples/webgl_shadowmap_performance.ts
+++ b/examples-testing/examples/webgl_shadowmap_performance.ts
@@ -14,16 +14,17 @@ const FLOOR = -250;
Expand Down Expand Up @@ -15783,7 +15783,7 @@ index 6fbdb55ae..fd5ec5705 100644
init();

diff --git a/examples-testing/examples/webgpu_custom_fog.ts b/examples-testing/examples/webgpu_custom_fog.ts
index 3a6c59a36..7736aa27e 100644
index f94daae6a..5baba5594 100644
--- a/examples-testing/examples/webgpu_custom_fog.ts
+++ b/examples-testing/examples/webgpu_custom_fog.ts
@@ -7,9 +7,17 @@ import { SkyMesh } from 'three/addons/objects/SkyMesh.js';
Expand Down Expand Up @@ -15832,7 +15832,7 @@ index a9b619345..e482a1e2e 100644
init();

diff --git a/examples-testing/examples/webgpu_custom_fog_scattering.ts b/examples-testing/examples/webgpu_custom_fog_scattering.ts
index e0da158f9..b1d30014d 100644
index 15f47cc12..126184066 100644
--- a/examples-testing/examples/webgpu_custom_fog_scattering.ts
+++ b/examples-testing/examples/webgpu_custom_fog_scattering.ts
@@ -6,7 +6,11 @@ import { FirstPersonControls } from 'three/addons/controls/FirstPersonControls.j
Expand Down Expand Up @@ -16259,7 +16259,7 @@ index ec0088e0e..6335c36db 100644
gui.add(parameters, 'height', 60, 200, 1).onChange(generate);
gui.add(parameters, 'width', 18, 60, 1).onChange(generate);
diff --git a/examples-testing/examples/webgpu_generator_city.ts b/examples-testing/examples/webgpu_generator_city.ts
index d1bf897ba..e49e9dfec 100644
index a0226ba9a..f4fa7cb7c 100644
--- a/examples-testing/examples/webgpu_generator_city.ts
+++ b/examples-testing/examples/webgpu_generator_city.ts
@@ -9,12 +9,26 @@ import { CityGenerator, createBuildingMaterial, createRoadMaterial } from 'three
Expand Down Expand Up @@ -16844,7 +16844,7 @@ index 944b5fc7c..2759ac0fa 100644
.name('GI')
.onChange(value => {
diff --git a/examples-testing/examples/webgpu_lightprobes_sponza.ts b/examples-testing/examples/webgpu_lightprobes_sponza.ts
index 9e4b280ce..0529b7fcc 100644
index 681122b1e..f8f5b4bc0 100644
--- a/examples-testing/examples/webgpu_lightprobes_sponza.ts
+++ b/examples-testing/examples/webgpu_lightprobes_sponza.ts
@@ -11,12 +11,16 @@ const MODEL_INDEX_URL =
Expand Down Expand Up @@ -16872,7 +16872,7 @@ index 9e4b280ce..0529b7fcc 100644

@@ -59,7 +63,7 @@ async function init() {
controls.movementSpeed = 2.0;
controls.lookSpeed = 0.16;
controls.lookSpeed = 0.2;

- const progressBar = document.getElementById('progressBar');
+ const progressBar = document.getElementById('progressBar') as HTMLProgressElement;
Expand Down Expand Up @@ -17428,7 +17428,7 @@ index e01b9823f..f39e53cb1 100644
renderer.render(scene, camera);
}
diff --git a/examples-testing/examples/webgpu_lights_sunlight.ts b/examples-testing/examples/webgpu_lights_sunlight.ts
index 4e8b36eb7..023df9efb 100644
index 8442c52bf..91811ab20 100644
--- a/examples-testing/examples/webgpu_lights_sunlight.ts
+++ b/examples-testing/examples/webgpu_lights_sunlight.ts
@@ -7,7 +7,16 @@ import { SkyMesh } from 'three/addons/objects/SkyMesh.js';
Expand Down Expand Up @@ -24772,7 +24772,7 @@ index 9c19b50f1..4766aca42 100644
gui.add(params, 'debug', debugTypes).name('voxel view').onChange(updatePostprocessing);
gui.add(giPass.debugLevel, 'value', 0, 4, 1).name('voxel view level');
diff --git a/examples-testing/examples/webgpu_vxgi_sponza.ts b/examples-testing/examples/webgpu_vxgi_sponza.ts
index af89131f2..c2da8cc56 100644
index 6bad88745..140767377 100644
--- a/examples-testing/examples/webgpu_vxgi_sponza.ts
+++ b/examples-testing/examples/webgpu_vxgi_sponza.ts
@@ -25,9 +25,14 @@ const MODEL_INDEX_URL =
Expand All @@ -24795,7 +24795,7 @@ index af89131f2..c2da8cc56 100644

@@ -76,7 +81,7 @@ async function init() {
controls.movementSpeed = 2.0;
controls.lookSpeed = 0.16;
controls.lookSpeed = 0.2;

- const progressBar = document.getElementById('progressBar');
+ const progressBar = document.getElementById('progressBar') as HTMLProgressElement;
Expand Down
2 changes: 1 addition & 1 deletion three.js
Open in desktop
Submodule three.js updated 14 files
+5 −5 examples/jsm/controls/FirstPersonControls.js
+1 −1 examples/webaudio_sandbox.html
+1 −1 examples/webgl_geometry_minecraft.html
+1 −1 examples/webgl_geometry_terrain.html
+1 −1 examples/webgl_lightprobes_sponza.html
+1 −1 examples/webgl_lights_sunlight.html
+1 −1 examples/webgl_shadowmap_performance.html
+1 −1 examples/webgpu_custom_fog.html
+1 −1 examples/webgpu_custom_fog_scattering.html
+1 −1 examples/webgpu_generator_city.html
+1 −1 examples/webgpu_lightprobes_sponza.html
+1 −1 examples/webgpu_lights_sunlight.html
+1 −1 examples/webgpu_vxgi_sponza.html
+212 −104 package-lock.json
Loading