Skip to content

[pull] master from google:master #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 2 commits into from
Sep 29, 2026
Merged

[pull] master from google:master #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c7e839
Add `strict_flag_check` to `CommandLineBinaryConfig` in `manifest.json`.
a-googler Sep 29, 2026
315cfa6
knot-dns: Update build.sh to accommodate new fuzzer (#16179)
arthurscchan Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions infra/base-images/base-builder/indexer/manifest_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,10 @@ class CommandLineBinaryConfig(BinaryConfig):
# are directly linked into the target binary. Should usually be true but
# some targets like V8 require this to be false, see b/433718862.
filter_compile_commands: bool = True
# Whether to enforce a strict flag allowlist for custom flags specified via
# `// Flags:` comments (when harness_kind is JS). Mostly needed for historic
# V8 builds that lack flag hardening (e.g. `--disallow-unsafe-flags`).
strict_flag_check: bool = False

@property
def uses_stdin(self) -> bool:
Expand All @@ -220,6 +224,7 @@ def from_dict(cls, config_dict: Mapping[str, Any]) -> Self:
filter_compile_commands=config_dict.get(
"filter_compile_commands", True
),
strict_flag_check=config_dict.get("strict_flag_check", False),
)


Expand Down
2 changes: 1 addition & 1 deletion projects/knot-dns/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ autoreconf -if
make -j$(nproc)
cd $SRC/knot-dns/tests-fuzz
make check
/bin/bash ../libtool --mode=install /usr/bin/install -c fuzz_packet fuzz_zscanner fuzz_dname_to_str fuzz_dname_from_str "$OUT"
/bin/bash ../libtool --mode=install /usr/bin/install -c fuzz_packet fuzz_zscanner fuzz_dname_to_str fuzz_dname_from_str fuzz_dnssec_verify "$OUT"

# Set up fuzzing seeds

Expand Down
Loading