Repository navigation
Add AdditionalCACerts to Configuration.Build - #3639
Open
jwong-beep wants to merge 3 commits into
Open
jwong-beep wants to merge 3 commits into
jwong-beep wants to merge 3 commits into
Conversation
This new config option add the ability to connect to a MitM'ing proxy
jwong-beep
requested review from
SpangleLabs,
peterebden,
scyyx5 and
toastwaffle
October 22, 2026 14:40
scyyx5
approved these changes
Oct 22, 2026
Contributor
|
Can you add more detail to the summary about why we want the additional CA? |
Author
|
added
…On Thu, 22 Oct 2026 at 16:02, Anya Xiao ***@***.***> wrote:
*scyyx5* left a comment (thought-machine/please#3639)
<#3639 (comment)>
Can you add more detail to the summary about why we want the additional CA?
—
Reply to this email directly, view it on GitHub
<#3639?email_source=notifications&email_token=BZEGGBHOGQ7MPAVY3WY5WOD5VIOPXA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMZUGM4TKNBTHA22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-6343954385>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BZEGGBAFKDKFC4TQAI4XESD5VIOPXAVCNFSNUABEKJSXA33TNF2G64TZHM2TAOJRGU4DMNZ3JFZXG5LFHM2TSOBRGUYDSOBXGSQXMAQ>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/BZEGGBENBEON7MIGEVWCO3T5VIOPXA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMZUGM4TKNBTHA22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/BZEGGBFBAPLDI2LWMZ3BHWD5VIOPXA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMZUGM4TKNBTHA22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Thought Machine Group Limited, a company registered in England & Wales.
Registered number: 11114277.
Registered Office: 5 New Street Square,
London EC4A 3TW
<https://maps.google.com/?q=5+New+Street+Square,+London+EC4A+3TW&entry=gmail&source=g>.
The content of this email is confidential and intended for the recipient
specified in message only. It is strictly forbidden to share any part of
this message with any third party, without a written consent of the sender.
If you received this message by mistake, please reply to this message and
follow with its deletion, so that we can ensure such a mistake does not
occur in the future.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
build.AdditionalCACertsconfig option: a list of PEM files containing CA certificatesto trust, in addition to the system trust store, for Please's own HTTPS downloads
(
remote_fileand self-update).Restricted environments often route downloads through a caching proxy that terminates TLS so it
can cache HTTPS responses, or serve them from an internal mirror. Either way the certificates are
issued by a private CA, which Please can't currently verify.
HTTPProxyhandles plain forwardingproxies but not this.
Notes:
go mod download)use their own trust settings.
HTTPProxyis set,fetchRemoteFilenow modifies the default transport rather thanreplacing it with a bare
http.Transport, so it keeps connection timeouts, connection poolingand HTTP/2.
remote_filetargets. Self-update only logs a warning andfalls back to the system trust store, since it runs on every invocation.
TestAdditionalCACertsruns a TLS server with a private cert and checks the downloadfails without the option and succeeds with it;
TestTLSConfigcovers the error cases.