Final refactor, tests pass - #3568
Closed
peterebden wants to merge 44 commits into
Closed
Conversation
…er and we pass the context around better
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3562 and #3565
This should be basically there now, tests are passing on my machine (although I intend to try to give it more of a workout). There might be some followup cleanup still, can imagine there are some things around the place that might not be needed any more, or can now be simplified.
I'll also create a single PR with it all combined, which will be mergeable. Then I guess we can see what the best way to review this piece of work is.