Skip to content

align toolkit SDL3 ugprade - #77

Merged
hermet merged 1 commit into
mainfrom
hermet/upgrade
Oct 5, 2026
Merged

hermet merged 1 commit into
mainfrom
hermet/upgrade

Conversation

@hermet

@hermet hermet commented Oct 5, 2026 •

Copy link
Copy Markdown
Member
  • upgrade SDL3 in the github build test
  • match Toolkit motion callback signatures

Copilot AI balanced review requested due to automatic review settings October 5, 2026 10:26
@hermet
hermet requested review from Nor-s and tinyjin as code owners October 5, 2026 10:26
@hermet hermet self-assigned this Oct 5, 2026
@hermet hermet added the refactoring Code refactoring / Exceptional handles label Oct 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

Both overrides consistently match the updated Toolkit callback signature.

Review effort: Balanced
Findings: None

What changed in this PR

Updates example motion handlers to match the Toolkit’s float-coordinate callback signature.

Changes:

  • Changes both motion overrides from integer to float coordinates.
File Description
src/​LottieInteraction.cpp Updates Lottie interaction motion signature.
src/​Intersects.cpp Updates intersection motion signature.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI balanced review requested due to automatic review settings October 5, 2026 10:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Intersects still truncates float coordinates into integer members, undermining the callback update.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)

Comment thread src/Intersects.cpp
Copilot AI balanced review requested due to automatic review settings October 5, 2026 10:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The callback and dependency updates are consistent, with only a non-blocking unused include cleanup identified.

Review effort: Balanced
Findings: None

Resolved since last review (1)

Copilot AI balanced review requested due to automatic review settings October 5, 2026 10:41

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The callback and dependency updates are consistent and complete.

Review effort: Balanced
Findings: None

Copilot AI balanced review requested due to automatic review settings October 5, 2026 10:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The unexplained CI platform and SDL migration materially exceeds the stated callback-update scope.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)

Comment thread .github/workflows/build_test.yml
Copilot AI balanced review requested due to automatic review settings October 5, 2026 10:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The dependency installation is split into separate shell commands, causing CI to fail.

Review effort: Balanced
Findings: 1 High severity · 1 Medium severity

Open (2)

Comment thread .github/workflows/build_test.yml Outdated
- upgrade SDL3 in the github build test
- match Toolkit motion callback signatures
Copilot AI balanced review requested due to automatic review settings October 5, 2026 10:50
@hermet hermet changed the title match Toolkit motion callback signatures align toolkit SDL3 ugprade Oct 5, 2026
@hermet
hermet removed request for Nor-s and tinyjin October 5, 2026 10:50

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The callback and CI updates are consistent and complete.

Review effort: Balanced
Findings: None

Resolved since last review (2)

@hermet
hermet merged commit 5c61ffd into main Oct 5, 2026
3 checks passed
@hermet
hermet deleted the hermet/upgrade branch October 5, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Code refactoring / Exceptional handles

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants