Skip to content

added motion blur - #75

Merged
hermet merged 1 commit into
mainfrom
hermet/motion
Oct 5, 2026
Merged

hermet merged 1 commit into
mainfrom
hermet/motion

Conversation

@hermet

@hermet hermet commented Sep 30, 2026

Copy link
Copy Markdown
Member

No description provided.

@hermet
hermet requested a balanced review from Copilot September 30, 2026 06:17
@hermet hermet self-assigned this Sep 30, 2026
@hermet hermet added the addition Adding a new example label Sep 30, 2026
@hermet
hermet removed request for Nor-s and tinyjin September 30, 2026 06:17
@hermet
hermet marked this pull request as draft September 30, 2026 06:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The diagonal angle calculation is incorrect for rectangular windows and uses non-portable M_PI.

Review effort: Balanced
Findings: 1 High severity

Open (1)
What changed in this PR

Adds a runnable motion-blur example demonstrating horizontal, vertical, and diagonal effects.

Changes:

  • Adds animated motion-blur scenes.
  • Registers the example in Meson.
File Description
src/​MotionBlur.cpp Implements the motion-blur example.
src/​meson.build Adds the example build target.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/MotionBlur.cpp Outdated
@hermet
hermet marked this pull request as ready for review October 5, 2026 05:57
Copilot AI balanced review requested due to automatic review settings October 5, 2026 06:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The implementation is focused and correctly integrated, with only a minor documentation correction noted.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
Resolved since last review (1)

Comment thread src/MotionBlur.cpp Outdated
Copilot AI balanced review requested due to automatic review settings October 5, 2026 06:18
@hermet
hermet merged commit 43448e2 into main Oct 5, 2026
3 checks passed
@hermet
hermet deleted the hermet/motion branch October 5, 2026 06:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The implementation is coherent; the noted error-handling inconsistency is non-blocking.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
Resolved since last review (1)

Comment thread src/MotionBlur.cpp

// motion blur effect scene
auto scene = tvg::Scene::gen();
scene->add(tvg::SceneEffect::MotionBlur, double(distance.y) * 0.1, 90.0, 100);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addition Adding a new example

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants