Skip to content

[Dashboard] Tighten login redirect path validation - #9011

Merged
0xFirekeeper merged 1 commit into
mainfrom
dashboard-login-redirect-path
Oct 12, 2026
Merged

0xFirekeeper merged 1 commit into
mainfrom
dashboard-login-redirect-path

Conversation

@0xFirekeeper

@0xFirekeeper 0xFirekeeper commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Login redirects now reject URLs on thirdweb.com whose paths begin with //. Redirects must still use the thirdweb.com hostname, keeping accepted destinations within the expected URL format.

@0xFirekeeper
0xFirekeeper requested review from a team as code owners October 12, 2026 09:14
@vercel

vercel Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
thirdweb-www Ready Ready Preview Oct 12, 2026 9:23am UTC
4 Skipped Deployments
Project Deployment Actions Updated
docs-v2 Skipped Skipped Oct 12, 2026 9:23am UTC
nebula Skipped Skipped Oct 12, 2026 9:23am UTC
thirdweb_playground Skipped Skipped Oct 12, 2026 9:23am UTC
wallet-ui Skipped Skipped Oct 12, 2026 9:23am UTC

@vercel
vercel Bot temporarily deployed to Preview – wallet-ui October 12, 2026 09:14 Inactive
@vercel
vercel Bot temporarily deployed to Preview – thirdweb_playground October 12, 2026 09:14 Inactive
@vercel
vercel Bot temporarily deployed to Preview – nebula October 12, 2026 09:14 Inactive
@vercel
vercel Bot temporarily deployed to Preview – docs-v2 October 12, 2026 09:14 Inactive
@changeset-bot

changeset-bot Bot commented Oct 12, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 56f8910

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added the Dashboard Involves changes to the Dashboard. label Oct 12, 2026
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: f7fa0ff0-eee7-4b14-8fd7-3b2c5845738e

📥 Commits

Reviewing files that changed from the base of the PR and between 3b6c18d and 56f8910.


📒 Files selected for processing (1)
  • apps/dashboard/src/app/login/isValidEncodedRedirectPath.ts

Included review availability: This review used your included allowance. Your plan provides up to 5 included reviews per hour; 3 remain after this review.



Walkthrough

The encoded redirect path validator now rejects URLs with a thirdweb.com hostname when the decoded pathname starts with //.

Changes

Redirect validation

Layer / File(s) Summary
Validate decoded redirect path
apps/dashboard/src/app/login/isValidEncodedRedirectPath.ts
The validator requires the parsed hostname to be thirdweb.com and the pathname not to start with //.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 56f89

The change blocks decoded paths beginning with //. The inspected accepted cases remain same-origin, with no concrete merge-blocking redirect risk established.

Pre-merge checks | Passed 3 | Failed 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check Warning The description only states that Claude Code generated the pull request. It does not explain the redirect validation change or provide testing details. Add a concise change summary under Notes for the reviewer and describe the unit tests or other testing performed under How to test.
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: tighter login redirect path validation in the Dashboard.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR

🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
@thirdweb-dev/nexus (esm) 105.66 KB (0%)
@thirdweb-dev/nexus (cjs) 319.47 KB (0%)

@0xFirekeeper
0xFirekeeper merged commit e0ed59f into main Oct 12, 2026
28 of 30 checks passed
@0xFirekeeper
0xFirekeeper deleted the dashboard-login-redirect-path branch October 12, 2026 10:37

This branch was successfully deployed

1 active and 4 inactive deployments
Preview – thirdweb-www — 56f89100 Deployed Oct 12, 2026 by vercel[bot]
Preview – wallet-ui — 56f89100 Deployed Oct 12, 2026 by vercel[bot]
Preview – thirdweb_playground — 56f89100 Deployed Oct 12, 2026 by vercel[bot]
Preview – docs-v2 — 56f89100 Deployed Oct 12, 2026 by vercel[bot]
Preview – nebula — 56f89100 Deployed Oct 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant