Skip to content

[Repo] Remove unused packages - #8948

Merged
0xFirekeeper merged 1 commit into
mainfrom
firekeeper/remove-unused-packages
Sep 11, 2026
Merged

0xFirekeeper merged 1 commit into
mainfrom
firekeeper/remove-unused-packages

Conversation

@0xFirekeeper

@0xFirekeeper 0xFirekeeper commented Sep 11, 2026 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Removals
    • Removed the Nebula package and Vault SDK from the repository.
    • Removed their public APIs, documentation, configuration, release histories, and tests.
    • Removed both packages from build, development, and dashboard workflows.
    • Removed package listings from project documentation.
  • Maintenance
    • Pinned the Wagmi CLI development dependency to version 2.8.0.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@0xFirekeeper
0xFirekeeper requested review from a team as code owners September 11, 2026 14:02
@vercel

vercel Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs-v2 Ready Ready Preview Sep 11, 2026 2:13pm UTC
nebula Ready Ready Preview Sep 11, 2026 2:13pm UTC
thirdweb_playground Ready Ready Preview Sep 11, 2026 2:13pm UTC
thirdweb-www Ready Ready Preview Sep 11, 2026 2:13pm UTC
wallet-ui Ready Ready Preview Sep 11, 2026 2:13pm UTC

@changeset-bot

changeset-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ef949c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 431287d3-5c3f-4432-a50c-1c4f6a29e52f

📥 Commits

Reviewing files that changed from the base of the PR and between c2b97d0 and ef949c4.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (43)
  • CLAUDE.md
  • README.md
  • apps/wagmi-demo/package.json
  • package.json
  • packages/nebula/CHANGELOG.md
  • packages/nebula/README.md
  • packages/nebula/biome.json
  • packages/nebula/openapi-ts.config.ts
  • packages/nebula/package.json
  • packages/nebula/src/client/client.gen.ts
  • packages/nebula/src/client/client/client.ts
  • packages/nebula/src/client/client/index.ts
  • packages/nebula/src/client/client/types.ts
  • packages/nebula/src/client/client/utils.ts
  • packages/nebula/src/client/core/auth.ts
  • packages/nebula/src/client/core/bodySerializer.ts
  • packages/nebula/src/client/core/params.ts
  • packages/nebula/src/client/core/pathSerializer.ts
  • packages/nebula/src/client/core/types.ts
  • packages/nebula/src/client/index.ts
  • packages/nebula/src/client/sdk.gen.ts
  • packages/nebula/src/client/types.gen.ts
  • packages/nebula/src/configure.ts
  • packages/nebula/src/exports/thirdweb.ts
  • packages/nebula/tsconfig.base.json
  • packages/nebula/tsconfig.build.json
  • packages/nebula/tsconfig.json
  • packages/vault-sdk/CHANGELOG.md
  • packages/vault-sdk/README.md
  • packages/vault-sdk/biome.json
  • packages/vault-sdk/package.json
  • packages/vault-sdk/src/exports/thirdweb.ts
  • packages/vault-sdk/src/sdk.ts
  • packages/vault-sdk/src/transaction-parser.ts
  • packages/vault-sdk/src/transaction-types.ts
  • packages/vault-sdk/src/types.ts
  • packages/vault-sdk/tests/.env.example
  • packages/vault-sdk/tests/env-setup.ts
  • packages/vault-sdk/tests/solana.test.ts
  • packages/vault-sdk/tsconfig.base.json
  • packages/vault-sdk/tsconfig.build.json
  • packages/vault-sdk/tsconfig.json
  • packages/vault-sdk/vitest.config.ts
💤 Files with no reviewable changes (40)
  • packages/vault-sdk/vitest.config.ts
  • packages/vault-sdk/tests/env-setup.ts
  • packages/vault-sdk/CHANGELOG.md
  • packages/nebula/CHANGELOG.md
  • packages/vault-sdk/biome.json
  • packages/nebula/tsconfig.base.json
  • packages/nebula/src/client/client.gen.ts
  • packages/vault-sdk/package.json
  • packages/nebula/README.md
  • CLAUDE.md
  • packages/nebula/src/configure.ts
  • packages/nebula/src/client/client/index.ts
  • packages/vault-sdk/tsconfig.build.json
  • packages/nebula/src/exports/thirdweb.ts
  • packages/vault-sdk/tests/solana.test.ts
  • packages/nebula/src/client/client/client.ts
  • packages/vault-sdk/README.md
  • packages/nebula/src/client/core/pathSerializer.ts
  • packages/vault-sdk/src/transaction-parser.ts
  • packages/nebula/tsconfig.json
  • packages/nebula/src/client/core/params.ts
  • packages/vault-sdk/tsconfig.json
  • packages/nebula/biome.json
  • packages/nebula/src/client/core/types.ts
  • packages/vault-sdk/tsconfig.base.json
  • packages/nebula/src/client/core/bodySerializer.ts
  • packages/nebula/openapi-ts.config.ts
  • packages/nebula/src/client/client/types.ts
  • packages/vault-sdk/tests/.env.example
  • packages/vault-sdk/src/transaction-types.ts
  • packages/nebula/src/client/core/auth.ts
  • packages/nebula/src/client/client/utils.ts
  • packages/vault-sdk/src/exports/thirdweb.ts
  • packages/nebula/package.json
  • README.md
  • packages/vault-sdk/src/types.ts
  • packages/nebula/tsconfig.build.json
  • packages/vault-sdk/src/sdk.ts
  • packages/nebula/src/client/sdk.gen.ts
  • packages/nebula/src/client/index.ts

Included review availability: Your plan provides up to 5 included reviews per hour; 3 remain after this review.


Walkthrough

The change retires the Nebula and Vault SDK packages, removes their implementations, exports, tests, documentation, and configuration, updates repository commands and package documentation, and pins the Wagmi CLI dependency to version 2.8.0.

Changes

Package retirement

Layer / File(s) Summary
Remove Nebula package
packages/nebula/...
Deletes the Nebula package manifest, generated client, API operations, configuration, exports, documentation, and TypeScript tooling.
Remove Vault SDK package
packages/vault-sdk/...
Deletes the Vault SDK manifest, public APIs, signing and account helpers, transaction parser, shared types, tests, documentation, and tooling.
Update repository references
CLAUDE.md, README.md, package.json
Removes the retired packages from documentation and development commands.

Wagmi CLI version pin

Layer / File(s) Summary
Pin Wagmi CLI dependency
apps/wagmi-demo/package.json
Changes @wagmi/cli from latest to 2.8.0.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to ef949

The package retirement and Wagmi CLI pin are consistent with the repository configuration and introduce no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided. The required reviewer notes and testing information are missing. Add a pull request description with reviewer notes and a How to test section. Document the package removals, any migration or compatibility impact, and the validation performed.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing unused packages. It is concise and related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch firekeeper/remove-unused-packages

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.68%. Comparing base (c2b97d0) to head (ef949c4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8948   +/-   ##
=======================================
  Coverage   51.67%   51.68%           
=======================================
  Files         937      937           
  Lines       63783    63783           
  Branches     4197     4208   +11     
=======================================
+ Hits        32962    32968    +6     
+ Misses      30724    30717    -7     
- Partials       97       98    +1     
Flag Coverage Δ
packages 51.68% <ø> (+<0.01%) ⬆️
see 4 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
@thirdweb-dev/nexus (esm) 105.66 KB (0%)
@thirdweb-dev/nexus (cjs) 319.47 KB (0%)

@0xFirekeeper
0xFirekeeper merged commit 04b480e into main Sep 11, 2026
25 checks passed
@0xFirekeeper
0xFirekeeper deleted the firekeeper/remove-unused-packages branch September 11, 2026 14:14

This branch was successfully deployed

5 active deployments
Preview – docs-v2 — ef949c42 Deployed Sep 11, 2026 by vercel[bot]
Preview – thirdweb-www — ef949c42 Deployed Sep 11, 2026 by vercel[bot]
Preview – thirdweb_playground — ef949c42 Deployed Sep 11, 2026 by vercel[bot]
Preview – nebula — ef949c42 Deployed Sep 11, 2026 by vercel[bot]
Preview – wallet-ui — ef949c42 Deployed Sep 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant