Skip to content

[Repo] Update test and build tooling - #8946

Merged
0xFirekeeper merged 1 commit into
mainfrom
firekeeper/update-tooling
Sep 11, 2026
Merged

0xFirekeeper merged 1 commit into
mainfrom
firekeeper/update-tooling

Conversation

@0xFirekeeper

@0xFirekeeper 0xFirekeeper commented Sep 11, 2026 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated Storybook tooling across dashboard, Nebula, UI, and shared packages.
    • Upgraded Vite, Vitest, coverage tooling, Sharp, and Turbo to newer versions.
    • Pinned the Wagmi CLI to a specific stable version for more predictable development workflows.
    • Refined workspace build and development scripts by removing an outdated package filter.

@0xFirekeeper
0xFirekeeper requested review from a team as code owners September 11, 2026 12:52
@vercel

vercel Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs-v2 Ready Ready Preview Sep 11, 2026 2:51pm UTC
nebula Ready Ready Preview Sep 11, 2026 2:51pm UTC
thirdweb_playground Ready Ready Preview Sep 11, 2026 2:51pm UTC
thirdweb-www Ready Ready Preview Sep 11, 2026 2:51pm UTC
wallet-ui Ready Ready Preview Sep 11, 2026 2:51pm UTC

@changeset-bot

changeset-bot Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a9aa061

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added the Dashboard Involves changes to the Dashboard. label Sep 11, 2026
@github-actions github-actions Bot added packages SDK Involves changes to the thirdweb SDK labels Sep 11, 2026
@coderabbitai

coderabbitai Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Warning

Review limit reached

  • Run on-demand review

On-demand reviews are free for the next 9 days. After that, they cost $0.25 per reviewed file.

Or wait 26 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 293ab2a0-2480-4653-b6d7-0d0c910ec8d7

📥 Commits

Reviewing files that changed from the base of the PR and between 6c725ef and a9aa061.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • packages/thirdweb/package.json

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 03e1e46c-09a6-48cd-b651-c17984c328be

📥 Commits

Reviewing files that changed from the base of the PR and between 7762262 and 6c725ef.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json

Included review availability: Your plan provides up to 5 included reviews per hour; 0 remain after this review.


Walkthrough

The pull request updates Storybook, Vitest, Vite, sharp, Wagmi CLI, and Turbo development dependencies. It also removes the Nebula workspace filter from selected root development scripts.

Changes

Development dependency updates

Layer / File(s) Summary
Storybook version updates
apps/dashboard/package.json, apps/nebula/package.json, packages/thirdweb/package.json, packages/ui/package.json
Storybook packages were updated from 9.0.15 to 9.1.20.
Test and build toolchain updates
apps/wagmi-demo/package.json, packages/service-utils/package.json, packages/thirdweb/package.json
Wagmi CLI, Vite, Vitest, coverage packages, and sharp were updated.
Workspace tooling and script routing
package.json
Turbo was updated from 2.5.4 to 2.9.18. Selected development scripts no longer include the Nebula workspace filter.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 6c725

The reviewed tooling updates and workspace script changes do not show a concrete merge-blocking risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request has no description. It does not provide the required reviewer notes, issue tag, or testing information from the repository template. Add a pull request description with the relevant issue tag, notes for the reviewer, and testing details. Include the required title format if applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the dependency and build-tooling updates. It is concise and related to the main changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch firekeeper/update-tooling

Comment @coderabbitai help to get the list of available commands.

@socket-security

socket-security Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

@socket-security

socket-security Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm storybook is 90.0% likely obfuscated

Confidence: 0.90

Location: Package overview

From: apps/dashboard/package.json → npm/storybook@9.1.20

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/storybook@9.1.20. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
Obfuscated code: npm storybook is 90.0% likely obfuscated

Confidence: 0.90

Location: Package overview

From: apps/dashboard/package.json → npm/storybook@9.1.20

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/storybook@9.1.20. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
Obfuscated code: npm storybook is 90.0% likely obfuscated

Confidence: 0.90

Location: Package overview

From: apps/dashboard/package.json → npm/storybook@9.1.20

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/storybook@9.1.20. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@codecov

codecov Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.67%. Comparing base (d114bc6) to head (a9aa061).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8946   +/-   ##
=======================================
  Coverage   51.67%   51.67%           
=======================================
  Files         937      937           
  Lines       63783    63783           
  Branches     4198     4198           
=======================================
  Hits        32962    32962           
  Misses      30723    30723           
  Partials       98       98           
Flag Coverage Δ
packages 51.67% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
@thirdweb-dev/nexus (esm) 105.66 KB (0%)
@thirdweb-dev/nexus (cjs) 319.47 KB (0%)

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@0xFirekeeper
0xFirekeeper merged commit 9b9d532 into main Sep 11, 2026
24 checks passed
@0xFirekeeper
0xFirekeeper deleted the firekeeper/update-tooling branch September 11, 2026 14:52

This branch was successfully deployed

5 active deployments
Preview – docs-v2 — a9aa0616 Deployed Sep 11, 2026 by vercel[bot]
Preview – thirdweb-www — a9aa0616 Deployed Sep 11, 2026 by vercel[bot]
Preview – thirdweb_playground — a9aa0616 Deployed Sep 11, 2026 by vercel[bot]
Preview – wallet-ui — a9aa0616 Deployed Sep 11, 2026 by vercel[bot]
Preview – nebula — a9aa0616 Deployed Sep 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant