Skip to content

[Dashboard] Close the unlock dialog on Enter and accept className - #8917

Merged
0xFirekeeper merged 1 commit into
mainfrom
dashboard/vault-review-followups
Aug 27, 2026
Merged

0xFirekeeper merged 1 commit into
mainfrom
dashboard/vault-review-followups

Conversation

@0xFirekeeper

@0xFirekeeper 0xFirekeeper commented Aug 27, 2026 •

Copy link
Copy Markdown
Member

Follow-ups from review on #8916.

  • Pressing Enter in the vault unlock dialog set the key but left the dialog open, while the button path closed it. Both paths now behave the same.
  • ListAccessTokens and RotateAdminKeyButton accept a className and merge it onto their root element.

Not taking the suggestion to split the seven server actions in @/actions/vault.ts into separate files — it is a file-layout change over freshly landed code with no behavioural benefit.

🤖 Generated with Claude Code


PR-Codex overview

This PR enhances the RotateAdminKeyButton and ListAccessTokens components by adding a className prop for better styling customization and updates the class name handling using the cn utility function.

Detailed summary

  • Added className? prop to RotateAdminKeyButton and ListAccessTokens.
  • Updated the className handling in RotateAdminKeyButton using cn.
  • Updated the className handling in ListAccessTokens using cn.
  • Added handleCloseModal() call in ListAccessTokens on Enter key press.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Bug Fixes

    • Pressing Enter while unlocking the vault now closes the unlock dialog after the key is set.
  • Improvements

    • Vault access-token lists and admin key rotation controls now support flexible styling for improved layout integration.

Pressing Enter in the vault unlock dialog set the key but left the dialog
open; the button path closed it. Both now behave the same.

Adds a className prop to ListAccessTokens and RotateAdminKeyButton so parents
can style them.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@0xFirekeeper
0xFirekeeper requested review from a team as code owners August 27, 2026 01:22
@vercel

vercel Bot commented Aug 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
thirdweb-www Ready Ready Preview Aug 27, 2026 1:31am
4 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs-v2 Skipped Skipped Aug 27, 2026 1:31am
nebula Skipped Skipped Aug 27, 2026 1:31am
thirdweb_playground Skipped Skipped Aug 27, 2026 1:31am
wallet-ui Skipped Skipped Aug 27, 2026 1:31am

@vercel
vercel Bot temporarily deployed to Preview – wallet-ui August 27, 2026 01:22 Inactive
@vercel
vercel Bot temporarily deployed to Preview – nebula August 27, 2026 01:22 Inactive
@vercel
vercel Bot temporarily deployed to Preview – docs-v2 August 27, 2026 01:22 Inactive
@vercel
vercel Bot temporarily deployed to Preview – thirdweb_playground August 27, 2026 01:22 Inactive
@changeset-bot

changeset-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0e8f7d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added the Dashboard Involves changes to the Dashboard. label Aug 27, 2026
@0xFirekeeper
0xFirekeeper merged commit 808f1bd into main Aug 27, 2026
20 of 22 checks passed
@0xFirekeeper
0xFirekeeper deleted the dashboard/vault-review-followups branch August 27, 2026 01:23
@coderabbitai

coderabbitai Bot commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e32aed1b-fd7b-4802-a0aa-43c0f49007ce

📥 Commits

Reviewing files that changed from the base of the PR and between ff40087 and 0e8f7d5.

📒 Files selected for processing (2)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/vault/components/list-access-tokens.client.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/vault/components/rotate-admin-key.client.tsx

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.


Walkthrough

Vault components now accept optional caller-provided CSS classes. The unlock dialog closes when Enter stores the unlock key.

Changes

Vault component updates

Layer / File(s) Summary
Access token styling and unlock flow
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/vault/components/list-access-tokens.client.tsx
ListAccessTokens accepts an optional className, merges it with the root classes, and closes the unlock dialog after Enter stores the key.
Admin key button styling
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/vault/components/rotate-admin-key.client.tsx
RotateAdminKeyButton accepts an optional className and merges it with the existing button classes.

Estimated code review effort: 1 (Trivial) | ~5 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dashboard/vault-review-followups

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.10%. Comparing base (b7e9c69) to head (0e8f7d5).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8917   +/-   ##
=======================================
  Coverage   53.10%   53.10%           
=======================================
  Files         935      935           
  Lines       63156    63156           
  Branches     4242     4243    +1     
=======================================
  Hits        33542    33542           
  Misses      29511    29511           
  Partials      103      103           
Flag Coverage Δ
packages 53.10% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
@thirdweb-dev/nexus (esm) 105.66 KB (0%)
@thirdweb-dev/nexus (cjs) 319.47 KB (0%)

This branch was successfully deployed

1 active and 4 inactive deployments
Preview – thirdweb-www — 0e8f7d5a Deployed Aug 27, 2026 by vercel[bot]
Preview – nebula — 0e8f7d5a Deployed Aug 27, 2026 by vercel[bot]
Preview – docs-v2 — 0e8f7d5a Deployed Aug 27, 2026 by vercel[bot]
Preview – thirdweb_playground — 0e8f7d5a Deployed Aug 27, 2026 by vercel[bot]
Preview – wallet-ui — 0e8f7d5a Deployed Aug 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant