Repository navigation
[Dashboard] Close the unlock dialog on Enter and accept className - #8917
Conversation
Pressing Enter in the vault unlock dialog set the key but left the dialog open; the button path closed it. Both now behave the same. Adds a className prop to ListAccessTokens and RotateAdminKeyButton so parents can style them. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Disabled knowledge base sources:
WalkthroughVault components now accept optional caller-provided CSS classes. The unlock dialog closes when Enter stores the unlock key. ChangesVault component updates
Estimated code review effort: 1 (Trivial) | ~5 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8917 +/- ##
=======================================
Coverage 53.10% 53.10%
=======================================
Files 935 935
Lines 63156 63156
Branches 4242 4243 +1
=======================================
Hits 33542 33542
Misses 29511 29511
Partials 103 103
🚀 New features to boost your workflow:
|
size-limit report 📦
|
Follow-ups from review on #8916.
ListAccessTokensandRotateAdminKeyButtonaccept aclassNameand merge it onto their root element.Not taking the suggestion to split the seven server actions in
@/actions/vault.tsinto separate files — it is a file-layout change over freshly landed code with no behavioural benefit.🤖 Generated with Claude Code
PR-Codex overview
This PR enhances the
RotateAdminKeyButtonandListAccessTokenscomponents by adding aclassNameprop for better styling customization and updates the class name handling using thecnutility function.Detailed summary
className?prop toRotateAdminKeyButtonandListAccessTokens.classNamehandling inRotateAdminKeyButtonusingcn.classNamehandling inListAccessTokensusingcn.handleCloseModal()call inListAccessTokenson Enter key press.Summary by CodeRabbit
Bug Fixes
Improvements