Skip to content

test(sidebar-handles-dock): switch the handle slide off while measuring #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexZ005 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(sidebar-handles-dock): switch the handle slide off while measuring #560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/e2e/sidebar-handles-dock.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,17 @@ const state = (page) =>
});
const settle = (page, ms = 700) => page.waitForTimeout(ms);
const near = (a, b) => a && b && Math.abs(a.top - b.top) <= 1;
// the handles slide on `top` (0.2 s); a transition advances only on painted frames, and a headless cloud build under
// load paints few, so a read 700 ms after a change can land mid-slide (production 1.66.0: 249 still drawn 1.5 s later).
// This suite measures WHERE a handle is drawn, so the slide is switched off.
const noSlide = (page) => page.addStyleTag({ content: '#sidebar-handle-left, #sidebar-handle-right { transition: none !important; }' });
const nodeEditor = (page) => page.locator('p[title="Node editor (N)"]').click();

h.run(async () => {
const browser = await h.launch();
const A = await h.setupPage(browser, 'A', { context: { viewport: { width: 1920, height: 1080 } } });
const page = A.page;
await noSlide(page);
await settle(page, 1500);

// ---- 1. a saved spot low on the screen ----
Expand Down Expand Up @@ -112,6 +117,7 @@ h.run(async () => {
const keep = st;
await h.freshReload(A);
await h.answerRestore?.(A);
await noSlide(page);
await settle(page, 2000);
st = await state(page);
h.check(near(st.left, keep.left) && near(st.right, keep.right), `6 a reload keeps both saved spots (${st.left?.top}/${keep.left?.top}, ${st.right?.top}/${keep.right?.top})`);
Expand Down
Loading