Fix - Header cart count and total stale after AJAX add to cart by rajatgautam755421 · Pull Request #143 · themegrill/spacious

rajatgautam755421 · 2026-09-25T04:40:44Z

Changes proposed in this Pull Request:

Fixes the free-theme part of themegrill/spacious-pro#109 (the issue notes it is also present in the free theme). The same fix for Pro is themegrill/spacious-pro#189, already reviewed by Copilot with approval recommended; this PR ports that final version.

The header cart (item count and total) was rendered once at page load and never registered as a WooCommerce cart fragment. After an AJAX add to cart, WooCommerce refreshed its own mini-cart, but the header badge and total kept their old values until the page was reloaded.

The header cart block now lives in one function, spacious_cart_icon_views(), used by both the initial render (spacious_cart_icon()) and a new woocommerce_add_to_cart_fragments filter (spacious_cart_icon_fragment()). Both new functions are wrapped in function_exists() like the rest of the file.

Effect on existing sites

Sites that do not use the header cart icon are unaffected: the filter returns early unless Customize > WooCommerce > Design > "Check to show WooCommerce cart icon on menu bar" is on.
The first page render is unchanged: the header cart HTML matches the original output. The render condition in spacious_cart_icon() is left exactly as it was.
A child theme that overrides spacious_cart_icon() keeps its own markup: the fragment filter is registered together with the default spacious_cart_icon(), so it is not added when that function is overridden.
The fragment never overwrites one that a plugin or child theme already supplies for the same selector.
The mini-cart widget inside .cart-wrapper is left alone; WooCommerce keeps updating it itself.

How to test the changes in this Pull Request:

Go to Customize > WooCommerce > Design, tick "Check to show WooCommerce cart icon on menu bar" and publish. Make sure WooCommerce > Settings > Products > "Enable AJAX add to cart buttons on archives" is on.
With an empty cart, open the Shop page. The header badge reads 0.
Click Add to cart on a product (the page must not reload) and wait for the "View cart" link. Before the fix the badge and total stay at 0 / $0.00 until you reload. After the fix they update straight away and match the mini-cart.
Add a second product, then remove items through the mini-cart. The badge and total follow each change, including back to 0 / $0.00.
Untick the cart icon setting and publish. The header cart disappears and nothing else changes.

Types of changes:

Bug fix (non-breaking change which fixes an issue)
Enhancement (modification of the currently available functionality)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Other information:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you successfully ran tests with your changes locally? Verified manually in the browser with Playwright (details below). No automated test was added.
Have you updated the documentation accordingly?

Changelog entry

Fix - Header cart count and total now update right after an AJAX add to cart, without a page reload.

Verification (Spacious 1.9.12, WooCommerce, logged-in session)

Reproduced on the original code first: after an AJAX add the header showed 0 / $0.00 while the mini-cart showed $32.00, and the AJAX response contained only div.widget_shopping_cart_content.
With the fix: adds update the header to 1 / $32.00 and 2 / $97.00, removals count down to 1 / $65.00 and 0 / $0.00, always matching the mini-cart, with a single header block. Each response includes the div.spacious-woocommerce-cart-views fragment.
The first-render header cart HTML is identical to the original when whitespace runs are collapsed.
Compatibility, tested with a temporary must-use plugin (since removed): with a simulated child-theme override of spacious_cart_icon() the page renders the override and the theme sends no header fragment; a site's own fragment for the same selector is preserved.
Cart icon setting off: WooCommerce's fragments contain only its own div.widget_shopping_cart_content.
Translations: the moved Total string changed its source line, so languages/spacious.pot was regenerated with the makepot options from Gruntfile.js. The diff is only the creation date and source line references.
PHPCS (WordPress standard) on inc/header-functions.php: no violations added or removed (42 errors and 8 warnings before and after, all in older code). PHPCompatibilityWP 7.4-: clean.

🤖 Generated with Claude Code

The header cart block was rendered once at page load and never registered as a WooCommerce cart fragment, so it only refreshed on a full reload while the mini-cart updated. Move the block into a shared function used by both the initial render and a woocommerce_add_to_cart_fragments filter. The filter is registered with the default spacious_cart_icon(), so a child theme overriding it keeps its own markup, and it never overwrites a fragment already supplied for the same selector. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Regenerated with the makepot options from Gruntfile.js. Only the creation date and source line references change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

github-actions · 2026-09-25T04:40:57Z

QA suite — refused, no regression spec

This PR changes product source but adds no spec, so the suite was
refused before booting WordPress — running it just to report the same
thing at the end costs runner minutes for nothing. Run
/claudegrill:verify-fix locally and let write-spec add the guard
to this branch, then push again.

Source files changed with no matching spec

inc/header-functions.php

rajatgautam755421 · 2026-09-25T04:41:14Z

Screenshots

Free Spacious theme, Shop page, cart started empty, then one product added with the AJAX Add to cart button (no page reload). The outline marks the header cart icon and the "View cart" link that appears once the add has succeeded.

Before (`develop`): header badge still `0`	After (this PR): header badge is `1` straight away

Copilot

Copilot review overview

🔵 Needs a closer look

Adjust fragment registration priority to preserve later-added fragments.

Review effort: Lite
Findings: None

What changed in this PR

Fixes stale WooCommerce header cart counts and totals after AJAX cart updates.

Changes:

Adds reusable header cart rendering and WooCommerce fragment support.
Preserves existing overrides and fragments.
Regenerates translation references.

File	Summary
`inc/header-functions.php`	Adds shared rendering and AJAX fragment synchronization; callback priority needs adjustment to prevent later providers from overwriting the fragment.
`languages/spacious.pot`	Updates generated translation metadata and source references.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

rajatgautam755421 · 2026-09-25T04:44:47Z

@tg-autopilot review

This ports the final, Copilot-approved version of themegrill/spacious-pro#189 to the free theme. Please review.

Copilot

Copilot review overview

🟢 Approval recommended

No unresolved review issues remain.

Review effort: Lite
Findings: None

rajatgautam755421 · 2026-09-25T04:47:33Z

Note on the first automated review ("adjust fragment registration priority to preserve later-added fragments"): no change needed. Plugins and child themes load before the parent theme's functions.php, so their woocommerce_add_to_cart_fragments filters at the default priority run before ours, and spacious_cart_icon_fragment() leaves an existing fragment for the same selector untouched. Filters added later, or at a later priority, run after ours and replace our value. Either way the other fragment is preserved, which is why the follow-up review reports no unresolved issues. This matches themegrill/spacious-pro#189.

subin-shk · 2026-09-28T06:19:11Z

Same issue as in pro. Cart count not updated dynamically after item removal from cart page.

@rajatgautam755421

The WooCommerce cart widget, which normally loads cart fragments, hides itself on the Cart and Checkout pages, so the header cart never refreshed there. The Cart and Checkout blocks also change the cart through the Store API without firing the events cart fragments listen for. Load cart fragments whenever the header cart icon is on, and when the Cart or Checkout block's cart store changes its item count or subtotal, trigger a fragment refresh so the header is re-rendered by spacious_cart_icon_views(). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

subin-shk

LGTM 👍🏼

iamprazol

LGTM !! 👍

* Fix - CI dependency install fails with pnpm 11 on Node 20 runners * Fix - Copilot review: use pnpm 10 instead of 9, and the real build-script allowlist key pnpm 9 doesn't gate install/postinstall scripts at all, so downgrading to it silently dropped the build-script allowlist protection pnpm 11 had (verified directly: pnpm 11 blocks an unlisted package's postinstall by default, pnpm 9 runs every package's scripts unconditionally). pnpm 10.34.5 declares the same Node >=18.12 compatibility as 9, so it still fixes the original CI failure, but keeps the same default-deny behavior as 11. Also switched pnpm-workspace.yaml from the pnpm 11-only "allowBuilds" map (confirmed not recognized by pnpm 10) to the documented, version-portable "onlyBuiltDependencies" array, which works correctly on both. * Fix - WooCommerce product page layout shows Right Sidebar but renders full width (#139) * Fix - Responsive menu shows enabled but never applies until saved once (#138) * Fix - Responsive menu shows enabled but never applies until saved once * Fix - Copilot review findings on the responsive-menu e2e suite Scopes the changeset cleanup to the suite's own admin user, represents an absent theme_mods row instead of throwing on a fresh install, restricts menu reuse to the primary location, maps inc/functions.php into the header area, fixes the mobile-menu-toggle spec to open the submenu's own caret toggle before asserting its content is visible, and publishes reverted Customizer values in cleanup (not just setting them) so Playground runs actually revert. Also fixes: a missing ignoreHTTPSErrors option that blocked the suite from ever running against a local DDEV site, and several specs calling setControl() on a page that had already navigated away from the Customizer. * Fix - auth.setup guards against a cold-boot fill race on Playground Waits for both login fields to be visible and confirms the password value actually landed before submitting, instead of filling immediately after goto(). A cold Playground boot can serve wp-login.php before it has fully hydrated, silently losing a fill() with no error. * Fix - Version theme scripts and styles with the theme version (#142) * Fix - Version theme scripts and styles with the theme version The main stylesheet and most theme scripts were enqueued without a version, so WordPress appended its own core version and browsers or CDNs kept serving old copies after a theme update until WordPress itself was updated. Pass SPACIOUS_THEME_VERSION, as the Customizer and admin assets already do. Handles, dependencies and load order are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Fix - Leave a child theme's stylesheet on its default version get_stylesheet_uri() is the child theme's own style.css when a child theme is active, so stamping it with the parent's version was wrong. Keep WordPress' default version there, exactly as before this change, and use the theme version only for Spacious' own stylesheet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Fix - Slider assets load unconditionally on the blog index due to an operator-precedence bug (#145) * Fix - Submenu caret icon never flips direction when toggled (#149) The sub-toggle click handler looked for a child matching ".sub-toggle .fa", but inside the handler `this` already is the .sub-toggle element itself, not a container of one - so the selector never matched anything and toggleClass() silently ran on an empty set. The submenu itself opened and closed correctly (a separate call), only the caret's own direction (caret-right/caret-down) never updated. Fixed by matching the icon's actual direct child selector, ".fa". Verified live in both themes: before the fix, clicking the caret expanded the submenu but the icon class never changed; after, it flips fa-caret-right <-> fa-caret-down correctly in both directions. Also checked and ruled out a previously-suspected duplicate id="site-navigation" theory: header.php's two spacious_main_nav() call sites are wrapped in genuinely mutually exclusive conditions (spacious_header_display_type === 'four' vs !== 'four'), so only one nav ever renders - confirmed with 0 duplicates under both settings, live. Nothing to fix there. * Fix - Deprecated IE-conditional html5shiv enqueue firing a notice on every page load (WP 6.9+) (#151) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Fix - navigation.js null errors on pages without the theme header (Widgets screen previews) (#147) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Fix - Search block input renders taller than its Search button (#148) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Fix - Meta box save routine reads $_POST without isset() checks or a value whitelist (#140) * Fix - Unbounded get_users() full-table scan in theme-switch cleanup (#144) * Fix - Missing capability check on free->pro migration trigger (#146) Adds current_user_can( 'edit_theme_options' ) alongside the existing nonce verification in the demo-import migration trigger, its notice, and its dismiss handler. The nonce alone only proved the request came from the current user's own session, not that they were allowed to run the action - any logged-in user, regardless of role, could force a site-wide theme_mods and options rewrite using stale legacy data, since the migration functions are hooked to after_setup_theme, which fires on the front end too. Verified live: a subscriber-role account, using a nonce genuinely valid for their own session, is now correctly rejected with "You do not have permission to perform this action." * Fix - Block borders set in the editor not showing on the front end (#150) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Fix - Header cart count and total stale after AJAX add to cart (#143) * Fix - Header cart count and total stayed stale after AJAX add to cart The header cart block was rendered once at page load and never registered as a WooCommerce cart fragment, so it only refreshed on a full reload while the mini-cart updated. Move the block into a shared function used by both the initial render and a woocommerce_add_to_cart_fragments filter. The filter is registered with the default spacious_cart_icon(), so a child theme overriding it keeps its own markup, and it never overwrites a fragment already supplied for the same selector. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Update translation template after moving the header cart strings Regenerated with the makepot options from Gruntfile.js. Only the creation date and source line references change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Fix - Update the header cart on the Cart and Checkout pages The WooCommerce cart widget, which normally loads cart fragments, hides itself on the Cart and Checkout pages, so the header cart never refreshed there. The Cart and Checkout blocks also change the cart through the Store API without firing the events cart fragments listen for. Load cart fragments whenever the header cart icon is on, and when the Cart or Checkout block's cart store changes its item count or subtotal, trigger a fragment refresh so the header is re-rendered by spacious_cart_icon_views(). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Fix - Block editor ignores Customizer typography and colors (#152) * Fix - Block editor ignores Customizer typography and colors Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Fix - Editor post title used the H1 size instead of the front-end title size Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Add - E2E guard: block editor matches the front-end Customizer typography and colors Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Remove - manually added E2E spec; specs come from the verify-fix flow Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Match footer credit wording to Pro's corrected punctuation spacious_footer_copyright()'s default text was missing a colon after "Theme" and carried a trailing period Pro's own fix already dropped - "Theme Spacious by ThemeGrill. Powered by: WordPress." here vs Pro's "Theme: Spacious Pro by ThemeGrill. Powered by: WordPress". Added the colon and removed the trailing period so both editions read the same way. Verified live: front end now shows "Theme: Spacious by ThemeGrill. Powered by: WordPress" with no trailing period. PHPCS unchanged (166 errors / 66 warnings, identical before and after). * Version bump to release of v1.10.0 * Default theme options to an empty array in the major controls migration get_option( $themename ) returns false whenever the option doesn't exist (fresh installs), and the subsequent unset() calls on that false value log PHP 8.1+ "Automatic conversion of false to array" deprecation notices on every after_setup_theme bootstrap until the migration flag is set. Ported from spacious-pro release/v2.8.0 (commit 7601809f), which fixed the same pattern against its own hardcoded 'spacious' option lookup. Verified live: reproduced 2 deprecation notices at migration.php:63 with the old spacious option absent, confirmed 0 after, via a real front-end request with Playwright against the Spacious theme. --------- Co-authored-by: Rajat Gautam <83450756+rajatgautam755421@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Prajjwal Poudel <iamprazol@gmail.com>

rajatgautam755421 and others added 2 commits September 25, 2026 10:25

Update translation template after moving the header cart strings

f6c1481

Regenerated with the makepot options from Gruntfile.js. Only the creation date and source line references change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

rajatgautam755421 self-assigned this Sep 25, 2026

rajatgautam755421 added bug severity:minor Works, but wrongly, with a workaround labels Sep 25, 2026

tg-autopilot requested a lite review from Copilot September 25, 2026 04:40

Copilot started reviewing on behalf of tg-autopilot September 25, 2026 04:41 View session

Copilot AI reviewed Sep 25, 2026

View reviewed changes

tg-autopilot requested a lite review from Copilot September 25, 2026 04:45

Copilot started reviewing on behalf of tg-autopilot September 25, 2026 04:45 View session

Copilot AI reviewed Sep 25, 2026

View reviewed changes

subin-shk self-requested a review September 28, 2026 07:11

subin-shk approved these changes Sep 28, 2026

View reviewed changes

iamprazol approved these changes Sep 28, 2026

View reviewed changes

iamprazol merged commit d7387a1 into develop Sep 28, 2026
1 check passed

iamprazol deleted the fix/109-header-cart-count-fragment branch September 28, 2026 07:27

iamprazol added the Approved label Sep 28, 2026

Navigation Menu

Fix - Header cart count and total stale after AJAX add to cart - #143

Fix - Header cart count and total stale after AJAX add to cart#143
iamprazol merged 3 commits into
developfrom
fix/109-header-cart-count-fragment

rajatgautam755421 commented Sep 25, 2026

Uh oh!

github-actions Bot commented Sep 25, 2026

Uh oh!

rajatgautam755421 commented Sep 25, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

rajatgautam755421 commented Sep 25, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

rajatgautam755421 commented Sep 25, 2026

Uh oh!

subin-shk commented Sep 28, 2026

Uh oh!

subin-shk left a comment

Uh oh!

iamprazol left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

rajatgautam755421 commented Sep 25, 2026

Uh oh!

github-actions Bot commented Sep 25, 2026

QA suite — refused, no regression spec

Uh oh!

rajatgautam755421 commented Sep 25, 2026

Screenshots

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

rajatgautam755421 commented Sep 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

rajatgautam755421 commented Sep 25, 2026

Uh oh!

subin-shk commented Sep 28, 2026

Uh oh!

subin-shk left a comment

Choose a reason for hiding this comment

Uh oh!

iamprazol left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants