Skip to content

Fix unbounded get_users() full-table scan in theme-switch notice cleanup #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamprazol merged 1 commit into from
Oct 1, 2026
Merged

Fix unbounded get_users() full-table scan in theme-switch notice cleanup #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions inc/admin/class-radiate-theme-review-notice.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,28 +181,29 @@ public function ignore_theme_review_notice_partially() {
* Remove the data set after the theme has been switched to other theme.
*/
public function review_notice_data_remove() {
$get_all_users = get_users();
$theme_installed_time = get_option( 'radiate_theme_installed_time' );

// Delete options data.
if ( $theme_installed_time ) {
delete_option( 'radiate_theme_installed_time' );
}

// Delete user meta data for theme review notice.
foreach ( $get_all_users as $user ) {
$ignored_notice = get_user_meta( $user->ID, 'radiate_ignore_theme_review_notice', true );
$ignored_notice_partially = get_user_meta( $user->ID, 'nag_radiate_ignore_theme_review_notice_partially', true );

// Delete permanent notice remove data.
if ( $ignored_notice ) {
delete_user_meta( $user->ID, 'radiate_ignore_theme_review_notice' );
}
// Only load users who actually have one of these notice-dismissal flags set.
$user_ids = get_users(
array(
'meta_query' => array(
'relation' => 'OR',
array( 'key' => 'radiate_ignore_theme_review_notice' ),
array( 'key' => 'nag_radiate_ignore_theme_review_notice_partially' ),
),
'fields' => 'ID',
)
);

// Delete partial notice remove data.
if ( $ignored_notice_partially ) {
delete_user_meta( $user->ID, 'nag_radiate_ignore_theme_review_notice_partially' );
}
// Delete user meta data for theme review notice.
foreach ( $user_ids as $user_id ) {
delete_user_meta( $user_id, 'radiate_ignore_theme_review_notice' );
delete_user_meta( $user_id, 'nag_radiate_ignore_theme_review_notice_partially' );
}
}
}
Expand Down
Loading