Skip to content

Fix unbounded get_users() in theme-switch review-notice cleanup #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamprazol merged 1 commit into from
Sep 30, 2026
Merged

Fix unbounded get_users() in theme-switch review-notice cleanup #115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 5 additions & 16 deletions inc/admin/class-flash-theme-review-notice.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,29 +182,18 @@ public function ignore_theme_review_notice_partially() {
* Remove the data set after the theme has been switched to other theme.
*/
public function review_notice_data_remove() {
$get_all_users = get_users();
$theme_installed_time = get_option( 'flash_theme_installed_time' );

// Delete options data.
if ( $theme_installed_time ) {
delete_option( 'flash_theme_installed_time' );
}

// Delete user meta data for theme review notice.
foreach ( $get_all_users as $user ) {
$ignored_notice = get_user_meta( $user->ID, 'flash_ignore_theme_review_notice', true );
$ignored_notice_partially = get_user_meta( $user->ID, 'nag_flash_ignore_theme_review_notice_partially', true );

// Delete permanent notice remove data.
if ( $ignored_notice ) {
delete_user_meta( $user->ID, 'flash_ignore_theme_review_notice' );
}

// Delete partial notice remove data.
if ( $ignored_notice_partially ) {
delete_user_meta( $user->ID, 'nag_flash_ignore_theme_review_notice_partially' );
}
}
// Delete user meta data for theme review notice, for every user in
// one query per key - avoids loading every user on the site just to
// unconditionally delete a key that either exists or doesn't.
delete_metadata( 'user', 0, 'flash_ignore_theme_review_notice', '', true );
delete_metadata( 'user', 0, 'nag_flash_ignore_theme_review_notice_partially', '', true );
}
}

Expand Down
Loading