Conversation
The zero case of comments_popup_link() was the fixed string "0 Comment", so a post with no comments read "0 Comment" while two or more read "2 Comments". It now reads "0 Comments". The msgid is updated in the .pot and the Hungarian and Polish .po files so the existing translations still match. Verified live: a post with zero comments rendered "0 Comment" before and "0 Comments" after.
QA suite — refused, no regression specThis PR changes product source but adds no spec, so the suite was Source files changed with no matching spec |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Rebuild and include the updated Hungarian and Polish MO catalogs.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates the zero-comment post meta label from “0 Comment” to “0 Comments” and synchronizes translation source files.
Changes:
- Updated the PHP display string.
- Updated POT and Hungarian/Polish PO entries.
- Compiled MO catalogs remain stale.
| File | Summary |
|---|---|
languages/pl_PL.po |
Updates the Polish translation entry. |
languages/hu_HU.po |
Updates the Hungarian translation entry. |
languages/accelerate.pot |
Updates the source catalog entry. |
inc/functions.php |
Changes the zero-comment label to plural. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
… string The compiled catalogs still held the old msgid, so those translations would stop applying. Only that msgid is changed; every other entry and the header are identical, checked by loading both files with WordPress's MO reader.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Free-theme counterpart of themegrill/accelerate-pro#52.
Changes proposed in this Pull Request:
A post with no comments showed "0 Comment" in the post meta while two or more showed "2 Comments". The zero argument of
comments_popup_link()ininc/functions.phpwas a fixed singular string. It now reads "0 Comments". The msgid is updated inaccelerate.pot,hu_HU.poandpl_PL.po(their existing translations are kept) so the string still matches.hu_HU.moandpl_PL.moare rebuilt with only that msgid changed (every other entry and the header are identical, checked by loading both files with the WordPress MO reader), so the existing translations still apply.Verified live on the blog listing with a post's comment count forced to 0 (temporary, since removed): before, "0 Comment"; after, "0 Comments".
How to test the changes in this Pull Request:
Types of changes:
Other information:
Changelog entry
Fix - Zero comment count now reads "0 Comments" instead of "0 Comment".