Repository navigation
IgnoreHeaders: avr/common.h, as avr/io*.h - #105
Merged
Merged
Conversation
SREG and the stack pointer, which every AVR has, are in avr/common.h, which <avr/io.h> includes as it does a part's header. include-cleaner took it for their provider and asked a file that writes SREG for it; found in MaxMatrix, whose bit banging saves and restores SREG.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A file that writes
SREG, as code does that holds the interrupts off and puts them back, failedmake tidy:misc-include-cleanerasked it to includeavr/common.h. avr-libc keeps the registers every AVR has there,SREGand the stack pointer among them, and<avr/io.h>includes it, as it includes a part's own header; include-cleaner does not take either back to<avr/io.h>.IgnoreHeadersalready leaves outavr/io*.hfor the part's headers and now leaves outavr/common.has well, so that<avr/io.h>is what a file includes forSREG.MaxMatrix ran into it when it turned the check on (its OIL 41, F-5) and added the pattern as an exception of its own, which it can drop after the update.
For a project: nothing to do.
How it was checked: a project made from this branch, its SelfCheck printing
SREG. With the old pattern,make tidyreportsno header providing "SREG" is directly included; with the new one it passes.tests/check.sh tidypasses.