Repository navigation
The examples a target compiles - #103
Merged
Merged
Conversation
An example of one board alone, as one of a timer only the Mega has, stops the compiler for any other board, so a project of several targets could have none: make examples compiled every example for every target, and make tidy read every one with each target's flags. EXAMPLES in target_settings() names the examples a target compiles, all of them if not set; make examples, the table of sizes and clang-tidy take those alone. A name that is no folder of examples/ fails, and so does an example no target compiles. tests/check.sh --targets gives the project an example for the Mega alone, which the Uno leaves out.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A project of several targets can now have an example for one board alone. Until now every example was compiled for every target, and read by clang-tidy with every target's flags, so an example that needs, say, a timer only the Mega has would break the build for the Uno.
A target now names the examples it compiles, in
EXAMPLESoftools/project.sh; without it, it compiles all of them, as before. Building the examples, the table of sizes and clang-tidy follow that list. A misspelt name in it fails, and so does an example that no target compiles, so that nothing goes unchecked without a word.For a project: nothing changes unless it sets
EXAMPLES. AtmegaTimer will use it for an example of the Mega's Timer3 to Timer5.How it was checked:
tests/check.sh --targetsnow gives the project an example that stops the compiler on any board but the Mega, which the Uno leaves out. It failed before the change, at the Uno compiling that example, and passes now: lint, tidy, cppcheck, headers, examples and self-check. A misspelt name and an example no target compiles were checked by hand, and each fails with its message.