Repository navigation
clang-tidy on main again: the backends' findings of the five checks #176 turned on - #180
Merged
Merged
Conversation
turned on #176 turned on bugprone-invalid-enum-default-initialization, clang-diagnostic-old-style-cast, cppcoreguidelines-pro-type-const-cast, -pro-type-cstyle-cast and modernize-use-scoped-lock on the strength of the survey of #175, and clang-tidy failed on main with 15 findings. The survey's count missed them: clang-tidy names the ESP32's and the RP2350's sources relative to their PlatformIO project, src/WebInterface.cpp, and the count kept only paths with a folder of the repository in front. - modernize-use-scoped-lock: std::scoped_lock, by CTAD, for the seven std::lock_guard of the ESP32's WordclockSerial, and the one of its host test along with them. - old-style-cast and cstyle-cast in WS2812Pio: the block by pio_get_instance() rather than as pio0 or pio1, which the SDK defines as C casts of an address; the host tests' stub of hardware/pio.h offers it. - old-style-cast in pdMS_TO_TICKS and HTTPD_DEFAULT_CONFIG: the casts are FreeRTOS's, inside the vendors' macros. A NOLINT with that reason, rather than writing the kernel's conversion or the server's defaults out again. - pro-type-const-cast: httpd takes a user_ctx and a payload that are not const, for its receiving path; a NOLINT at each of the three, under the reason the code already gave. - invalid-enum-default-initialization: the RMT channel's configuration is zeroed first, as the IDF's examples do, and its clock source set two lines later; a NOLINT with that reason. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`main` has been red in the clang-tidy job since #176: the five checks it turned on find 15 things in `platform/esp32` and `platform/rp2350`. The survey of #175 missed them because clang-tidy names those sources relative to their PlatformIO project (`src/WebInterface.cpp`), and the count kept only paths with a folder of the repository in front.
Checked locally: `tools/tidy.sh` (all three targets, host tests, fuzzers) finds nothing, `make lint`, `make host-esp32 host-rp2350`, and `pio run` for both the ESP32 and the RP2350 build.
🤖 Generated with Claude Code