Repository navigation
OIL 41, chapter Types: the host code - #130
Merged
Merged
Conversation
No assignment or second side effect stands in a condition any more (T-14): the hosts accept in a loop that declares what it accepted, the link finds each line end in a statement of its own, and the setup of a listener, a serial port and a WebSocket client is a named step per call. A variable stands where it is first needed, and the length field of a WebSocket frame and its payload's length are two (T-13). Conditions and sums of several parts are named steps (T-18), a range-for names its element's type (T-8), and the count of lit LEDs in DocuPictures is a uint16_t, as all 256 would wrap a byte (T-1). The control program's stroke rounds with integers as lround() did, without its double (H-7). The library and its sizes do not change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing changes for a sketch or for whoever uses the simulator or the control program. The library is untouched, and every example has the same flash and RAM as on main.
The second pull request of the review of the chapter Types in OIL item 41, for the simulator, the control program and
DocuPictures:fornames its element's type, and a count that could reach 256 is no longer a byte.doublethe coding style forbids (H-7).Checked:
make checkpasses: lint, clang-tidy, every host and AVR test, coverage at 100 % of lines, branches and conditions.