Repository navigation
OIL 41, chapter Types: the library - #129
Merged
Merged
Conversation
A char is stored and the line's length counted in two statements (T-14), and ChangeMapping() walks its pairs of modules by one counter rather than two in one declaration (T-13, T-14). The header of a font is read by one function into a struct, where CheckFont() and GetGlyph() each assigned four variables declared ahead (T-13), which also takes a copy the chapter Functions missed (FN-13). Command passes a command with a value on in a function of its own (T-13). A condition of three parts and a sum in a condition are named steps (T-18), and the auto of a port register says why its type cannot be written (T-8). On the Uno, in every variant, every example is 8 bytes of flash smaller, Shutdown 12 and SerialControl 22; RAM is the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing changes for a sketch but its size: every example is 8 bytes of flash smaller on the Uno, in all three variants (bit banging, SPI,
MAXMATRIX_DEV_ERROR_DETECT), Shutdown 12 and SerialControl 22; RAM is the same.The first pull request of the review of the chapter Types of the coding style in OIL item 41, for the library; the host code follows. The rules review checks there, as the tools already pass:
autowhose type does not stand in its line says why it cannot be written: the register is a byte on the board and an object of the mock's on the host.Nothing to change for T-1, T-19 and T-23.
Checked:
make checkpasses: lint, clang-tidy, every host and AVR test, coverage at 100 % of lines, branches and conditions.