Repository navigation
OIL 41, chapter Functions: the rest in the host code - #128
Merged
Merged
Conversation
Printing the panel at the end of a run and comparing it with --expect are two functions (FN-1), as are writing the pictures of DocuPictures and checking them; a picture it cannot write is reported now. IsUpright() returns at the first dot that differs, and the name MD_MAX72XX gives a wiring is found by a function of its own (FN-14). DocuSvg takes its paint and font by const&, the control program a wxPoint by value (FN-7); a few helpers are constexpr (FN-9); the simulator's panel holds its wiring by std::reference_wrapper (FN-15); SimulatorAvr::TakeByte() is not const, as it writes the frame (FN-11); DocuPictures reads a file through SimulatorFile (FN-13). The swappable pairs clang-tidy cannot see are left, as a test fails on a swap of each; the web test now pins the page's status and type as well. The library and its sizes do not change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing changes for a sketch.
DocuPictures --writenow says so when it cannot write a picture, where it failed without a word before; everything else behaves as before. The library is untouched, and every example has the same flash and RAM as on main.The last pull request of the review of the chapter Functions in OIL item 41: the single findings left in the simulator, the control program and
DocuPictures.const&and a point of 8 by value; a few helpersconstexpr; a function that writes the frame notconst; the simulator's wiring, which always exists, held bystd::reference_wrapperrather than a pointer.DocuPicturesread files with a copy of the simulator's file reader, and uses it now.Checked:
make checkpasses: lint, clang-tidy, every host and AVR test, coverage at 100 % of lines, branches and conditions.DocuPictures --writeinto an empty folder writes the pictures indocu/byte for byte,--checkof that folder passes, and--writeinto a folder that does not exist reports every picture.