Add completion audit and refine Swift guidance - #16
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 20d28035a1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent-guidelines-auditskill and make it a mandatory completion gate before handoff, pull requests, merge readiness, and releases0.0.13for release after review and mergeWhy
The Maskaroo Redux adoption exposed gaps between the intended shared conventions and what consumer agents could reliably discover and audit. These changes make the expected organization and completion checks explicit while keeping product-specific decisions in consumer repositories.
Consumer impact
After
0.0.13is reviewed, merged, and released, consumers can update their tracked subtree, expose the audit skill through.agents/skills, and adopt the canonical Store and refined organization guidance deliberately.Validation
./Scripts/swift_format.sh format-and-lint Templatespython3 Scripts/validate_guidelines.py— validated 16 guidelines for version 0.0.13python3 -m unittest discover Tests— 7 tests passedquick_validate.py— skill is validgit diff --checkValidate guidelines— passed for the review-fix commitRelease gate
Do not tag or release
0.0.13until review comments are resolved, required checks pass, and the pull request is approved and merged.