Skip to content

Add completion audit and refine Swift guidance - #16

Merged
backslash-f merged 2 commits into
mainfrom
codex/add-agent-guidelines-audit
Jul 25, 2026
Merged

Add completion audit and refine Swift guidance#16
backslash-f merged 2 commits into
mainfrom
codex/add-agent-guidelines-audit

Conversation

@backslash-f

@backslash-f backslash-f commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add the reusable agent-guidelines-audit skill and make it a mandatory completion gate before handoff, pull requests, merge readiness, and releases
  • add the canonical Redux Store template with main-actor middleware isolation, plus dependency-container and middleware-composition guidance
  • clarify physical folder ownership, familiar domain grouping, model-versus-tool classification, service-local helpers, presentation models, documentation, SwiftUI structure, and actor-isolation defaults
  • enable conditional-import sorting and extend validation for the formatting policy, audit skill, Stack guidance, and Swift templates
  • prepare version 0.0.13 for release after review and merge

Why

The Maskaroo Redux adoption exposed gaps between the intended shared conventions and what consumer agents could reliably discover and audit. These changes make the expected organization and completion checks explicit while keeping product-specific decisions in consumer repositories.

Consumer impact

After 0.0.13 is reviewed, merged, and released, consumers can update their tracked subtree, expose the audit skill through .agents/skills, and adopt the canonical Store and refined organization guidance deliberately.

Validation

  • ./Scripts/swift_format.sh format-and-lint Templates
  • python3 Scripts/validate_guidelines.py — validated 16 guidelines for version 0.0.13
  • python3 -m unittest discover Tests — 7 tests passed
  • skill-creator quick_validate.py — skill is valid
  • git diff --check
  • GitHub Actions Validate guidelines — passed for the review-fix commit

Release gate

Do not tag or release 0.0.13 until review comments are resolved, required checks pass, and the pull request is approved and merged.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 20d28035a1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Templates/Store.swift Outdated
@backslash-f
backslash-f merged commit 64ac63d into main Jul 25, 2026
1 check passed
@backslash-f
backslash-f deleted the codex/add-agent-guidelines-audit branch July 25, 2026 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant