Run swift-format before compilation - #14
Merged
Merged
Conversation
Contributor
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9af42b9887
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
format-and-lintcommand and guidance for a pre-compilation Xcode build phaseValidateDocumentationCommentsplus four conservative SwiftLint-aligned rules0.0.11Rule review
Enabled beyond the Xcode 27 dump:
AlwaysUseLiteralForEmptyCollectionInitNeverUseForceTryNoEmptyLinesOpeningClosingBracesUseWhereClausesInForLoopsValidateDocumentationCommentsThe guide records deliberately deferred rules and notes that repository-specific import bans and sorted enum cases have no swift-format equivalent.
Validation
python3 -m unittest discover -s Testspython3 Scripts/validate_guidelines.pybash -n Scripts/swift_format.shgit diff --checkxcrun swift-format dump-configurationformat-and-lintandlint-strictwith an incomplete documentation fixture; warnings remained non-blocking locally and strict lint failed as expected