Fix deprecated map.field call on Elixir 1.19 - #150
Merged
Conversation
Invoking the generated __live_admin_config__/0 via map.field notation is deprecated as of Elixir 1.19 and will break in a future release. Add the parentheses so it is an explicit function call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds parentheses to the
__live_admin_config__call inLiveAdmin.associated_resource/4.Why
Invoking the generated
__live_admin_config__/0viamap.fieldnotation (resource.__live_admin_config__) is deprecated as of Elixir 1.19 and emits a warning at runtime; it will break in a future release. Making it an explicit function call (resource.__live_admin_config__()) resolves the deprecation.Verification
mix do compile --warnings-as-errors + test— clean compile, 45 tests, 0 failures; the deprecation warning no longer appears in test output🤖 Generated with Claude Code