#441 refactor: Update brace level check to handle traits in function … - #448
Open
Ollec wants to merge 1 commit into
Open
#441 refactor: Update brace level check to handle traits in function …#448Ollec wants to merge 1 commit into
Ollec wants to merge 1 commit into
Conversation
…unction body detection
Ollec
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug where PHP traits with multiple functions only detected the first function, which incorrectly spanned the entire file. The issue was in _function_body() - the condition to detect function end used self.in_class but didn't account for self.in_trait. Functions inside traits now correctly end at brace level 1, same as classes. Fixes the issue reported for lizard 1.18.
Resolves: #441