feat(bench): wait for validator readiness before measurement - #215
Merged
Merged
Conversation
joshieDo
changed the title
joshieDo
marked this pull request as ready for review
September 21, 2026 12:32
mediocregopher
approved these changes
Sep 21, 2026
mattsse
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds validator readiness gates to
bench send: wait for every validator to finalize a self-proposed block, settle submissions, clear txpools, confirm pending/queued are empty, then wait for Finish checkpoints to cover a fixed post-drain height. Missing metrics or timeouts abort. Requires debug RPC and state masking disabled; proposer coverage does not prove block size.Measurement uses the same sender with fresh metrics and its own duration. Reports retain preparation timestamps and per-validator evidence. The generator handles the timed consumer closing its pipe, with buffered NDJSON serialization to avoid formatter panics. Optional timed
--warmupremains available; preparation defaults to off.Validated: readiness success/timeout integration, metric validation, and nightly formatting pass after cleanup. Earlier CI and the cloud run passed: https://github.com/tempoxyz/tempo-multi-region-benchmark/actions/runs/35255381224. Runner integration: https://github.com/tempoxyz/tempo-multi-region-benchmark/pull/412.