Conversation
Add version status to worker deployment describe-version - #1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
I was working on a script to clean up old worker pools for drained versions using the GCP Cloud Run Serverless Worker pool, and I realized there was a failed deploy that left an inactive worker pool which my script was not handling, and the pool and version was just hanging around forever. But there is not a status field that includes the "inactive" state in the CLI, like the one that exists in the temporal cloud WebUI, so I decided to add it here.
temporal worker deployment describe-versionnow shows the version's lifecycle status (inactive,current,ramping,draining,drained,created). This is just the existing status enum that is already returned by the SDK lowercased. So:Statusrow.--output jsonhas a new top-levelstatusfield.Checklist
Stability
statusfield only)Design
Behavior
Tests
SharedServerSuite:TestDeployment_Describe_Drainagefor both json and human friendly output modes.Manual tests
Setup
Happy path
Error case