馃挜 Includes input/output for nexus op describe JSON - #1225
Merged
Merged
Conversation
S15
marked this pull request as ready for review
October 2, 2026 18:58
bergundy
approved these changes
Oct 2, 2026
Quinn-With-Two-Ns
approved these changes
Oct 2, 2026
Contributor
|
I approved the code changes. Since this changes the cli output, it will be useful to show a sample test commands and output in the PR description, as recommended by the PR template. If you decide to do this, please update the PR description with the example before merge. Thanks. |
ks-temporal
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Includes input and output for nexus operation describe json output. Matches activity describe.
This changes the JSON output, moving the existing output under the 'info' property and including top-level input, result or failure fields.
This also changes the --raw output to include the Info wrapper.
Checklist
Stability
-o json/-o jsonl) are treated as breaking changesDesign
Behavior
Tests
SharedServerSuite)func TestXxx) where applicableManual tests
Happy path
Successful Operation:
{ "runId": "...", "info": { "operationId": "myOperationId", "runId": "...", "endpoint": "myEndpoint", "service": "myService", "operation": "myOperation", "status": "NEXUS_OPERATION_EXECUTION_STATUS_COMPLETED", "attempt": 1, "scheduleTime": "2026-10-02T22:11:15.505571Z", "closeTime": "2026-10-02T22:11:17.524073Z", "lastAttemptCompleteTime": "2026-10-02T22:11:15.512824Z", "executionDuration": "2.018502s", "requestId": "...", "operationToken": "...", "stateTransitionCount": "3", "searchAttributes": {}, "userMetadata": { "summary": "My test operation" }, "links": [ { "workflowEvent": { "namespace": "default", "workflowId": "...", "runId": "...", "eventRef": { "eventId": "1", "eventType": "EVENT_TYPE_WORKFLOW_EXECUTION_STARTED" } } } ], "stateSizeBytes": "1029" }, "input": { "Name": "World" }, "result": { "Greeting": "Hello World" } }Failed operation:
{ "runId": "...", "info": { "operationId": "myOperationId", "runId": "...", "endpoint": "myEndpoint", "service": "myService", "operation": "myOperation", "status": "NEXUS_OPERATION_EXECUTION_STATUS_FAILED", "attempt": 1, "scheduleTime": "2026-10-02T22:18:49.121318Z", "closeTime": "2026-10-02T22:18:49.125985Z", "lastAttemptCompleteTime": "2026-10-02T22:18:49.125985Z", "lastAttemptFailure": { "message": "expected failure", "source": "GoSDK", "applicationFailureInfo": { "type": "OperationError", "nonRetryable": true } }, "executionDuration": "0.004667s", "requestId": "...", "stateTransitionCount": "2", "searchAttributes": {}, "userMetadata": { "summary": "My failing operation" }, "stateSizeBytes": "811" }, "input": { "Reason": "expected failure" }, "failure": { "message": "expected failure", "source": "GoSDK", "applicationFailureInfo": { "type": "OperationError", "nonRetryable": true } }, }