Enable standalone nexus operations in devserver, and support delete - #1221
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f69ffbe2ba
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The command is consistently implemented, documented, registered, and covered by functional tests.
Review effort: Balanced
Findings: None
What changed in this PR
Adds deletion support for Nexus Operation Executions and enables standalone Nexus Operations in the development server.
Changes:
- Adds interactive and JSON-capable
nexus operation delete. - Enables standalone Nexus Operations in devserver.
- Adds functional coverage for deletion, run IDs, JSON output, and validation.
| File | Description |
|---|---|
internal/temporalcli/commands.yaml |
Defines the delete command and help text. |
internal/temporalcli/commands.nexus_operation.go |
Implements confirmation, deletion, warnings, and output. |
internal/temporalcli/commands.nexus_operation_test.go |
Tests deletion behavior and output. |
internal/temporalcli/commands.gen.go |
Registers the generated command and flags. |
internal/temporalcli/commands_test.go |
Enables immediate Nexus endpoint refresh in tests. |
internal/devserver/server.go |
Enables standalone Nexus Operations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
temporal nexus operation deletetemporal nexus operation delete
temporal nexus operation delete
ks-temporal
left a comment
There was a problem hiding this comment.
I edited the title to that that action is not lost in the next cli release notes, and I changed checkbox from unit test to functional test (SharedServerSuite, I believe, indicates functional test).
It may be useful to include a test to verify that it deletes the latest run if runId is not supplied. I approved, but let me know if you decide to add that. Thanks
What changed?
temporal nexus operation deleteChecklist
Design
temporal <noun> <verb>structure (e.g.temporal workflow start)--search-attribute, bad:--index-field)(Experimental)incommands.yamlHelp text (see style guide at the top of
commands.yaml)--namespace, not-n), one flag per lineYourXxxform (YourWorkflowId,YourNamespace)Behavior
Tests
SharedServerSuite)func TestXxx) where applicable