Skip to content

Enable standalone nexus operations in devserver, and support delete - #1221

Merged
S15 merged 7 commits into
mainfrom
sammm/nexusOperationDelete
Sep 30, 2026
Merged

S15 merged 7 commits into
mainfrom
sammm/nexusOperationDelete

Conversation

@S15

@S15 S15 commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

What changed?

  • Enables standalone nexus operations in devserver
  • Adds support for temporal nexus operation delete

Checklist

Design

  • This feature does not depend on Cloud-only APIs or behavior (it works against an OSS server)
  • New commands follow temporal <noun> <verb> structure (e.g. temporal workflow start)
  • New flags are named after the API concept, not the implementation mechanism (good: --search-attribute, bad: --index-field)
  • New flags don't duplicate an existing flag that serves the same purpose
  • New flags do not have short aliases without strong justification
  • Experimental features are marked with (Experimental) in commands.yaml

Help text (see style guide at the top of commands.yaml)

  • All flags shown in help text and examples are implemented and functional
  • Summaries use sentence case and have no trailing period
  • Long descriptions end with a period and include at least one example invocation
  • Examples use long flags (--namespace, not -n), one flag per line
  • Placeholder values use YourXxx form (YourWorkflowId, YourNamespace)

Behavior

  • Results go to stdout; errors and warnings go to stderr
  • Error messages are lowercase with no trailing punctuation

Tests

  • Added functional test(s) (SharedServerSuite)
  • Added unit test(s) (func TestXxx) where applicable

@CLAassistant

CLAassistant commented Sep 29, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@S15
S15 marked this pull request as ready for review September 29, 2026 20:44
@S15
S15 requested a review from a team as a code owner September 29, 2026 20:44

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f69ffbe2ba

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread internal/temporalcli/commands.nexus_operation_test.go

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The command is consistently implemented, documented, registered, and covered by functional tests.

Review effort: Balanced
Findings: None

What changed in this PR

Adds deletion support for Nexus Operation Executions and enables standalone Nexus Operations in the development server.

Changes:

  • Adds interactive and JSON-capable nexus operation delete.
  • Enables standalone Nexus Operations in devserver.
  • Adds functional coverage for deletion, run IDs, JSON output, and validation.
File Description
internal/​temporalcli/​commands.yaml Defines the delete command and help text.
internal/​temporalcli/​commands.nexus_operation.go Implements confirmation, deletion, warnings, and output.
internal/​temporalcli/​commands.nexus_operation_test.go Tests deletion behavior and output.
internal/​temporalcli/​commands.gen.go Registers the generated command and flags.
internal/​temporalcli/​commands_test.go Enables immediate Nexus endpoint refresh in tests.
internal/​devserver/​server.go Enables standalone Nexus Operations.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@ks-temporal ks-temporal changed the title Support temporal nexus operation delete Enable standalone nexus operations in devserver, and support temporal nexus operation delete Sep 30, 2026
@ks-temporal ks-temporal changed the title Enable standalone nexus operations in devserver, and support temporal nexus operation delete Enable standalone nexus operations in devserver, and support delete Sep 30, 2026

@ks-temporal ks-temporal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I edited the title to that that action is not lost in the next cli release notes, and I changed checkbox from unit test to functional test (SharedServerSuite, I believe, indicates functional test).

It may be useful to include a test to verify that it deletes the latest run if runId is not supplied. I approved, but let me know if you decide to add that. Thanks

@S15
S15 added this pull request to the merge queue Sep 30, 2026
Merged via the queue into main with commit 7308be6 Sep 30, 2026
11 checks passed
@S15
S15 deleted the sammm/nexusOperationDelete branch September 30, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants