Support screen reader focus and activate on chat list rows#30769
Open
rezabakhshilaktasaraei wants to merge 2 commits into
Open
Support screen reader focus and activate on chat list rows#30769rezabakhshilaktasaraei wants to merge 2 commits into
rezabakhshilaktasaraei wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chat list rows are painted/virtual (no real
QWidget), so a screen reader couldn't move focus to a row or activate one. With the action interface added in desktop-app/lib_ui#303, those requests now reachInnerWidget:Move focus (e.g. NVDA+Shift+Numpad Minus) ->
accessibilityChildSetFocus(int index):announceSelectedFocus()path.Activate (e.g. NVDA+Numpad Enter / UIA Invoke) ->
accessibilityChildActivate(int index):chooseRow().The selection logic shared by both is extracted into
selectChildByIndex(), and the filtered-mode scroll is extracted fromselectSkip()into a reusablescrollToFilteredSelected().Depends on desktop-app/lib_ui#303 (adds the
accessibilityChildSetFocus/accessibilityChildActivatevirtuals); CI will not compile until that is merged and the submodule is updated.