Skip to content

Fix macOS consumer CI install permissions #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 3 commits into from
+9 −2
Closed

Fix macOS consumer CI install permissions #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4f7318
Initial plan
Copilot Sep 3, 2026
c809998
Install consumer CI package locally
Copilot Sep 3, 2026
909dcf5
Fix consumer package dependency discovery
Copilot Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,7 @@ jobs:
-DTRX_BUILD_TESTS=ON \
-DTRX_BUILD_EXAMPLES=ON \
-DTRX_ENABLE_NIFTI=ON \
-DCMAKE_INSTALL_PREFIX="${GITHUB_WORKSPACE}/install" \
-DCMAKE_BUILD_TYPE=Release \
${{ runner.os == 'Windows' && format('-DCMAKE_TOOLCHAIN_FILE={0}/vcpkg/scripts/buildsystems/vcpkg.cmake', github.workspace) || '' }}

Expand Down Expand Up @@ -311,10 +312,15 @@ jobs:
}
EOF

prefix_path="${GITHUB_WORKSPACE}/install"
if [[ "$RUNNER_OS" == "macOS" ]]; then
prefix_path="$(brew --prefix);${prefix_path}"
fi
cmake -S "$consumer" -B "$consumer/build" \
-G Ninja \
-DCMAKE_BUILD_TYPE=Release \
-DCMAKE_PREFIX_PATH="${GITHUB_WORKSPACE}/build"
-DCMAKE_PREFIX_PATH="$prefix_path" \
${{ runner.os == 'Windows' && format('-DCMAKE_TOOLCHAIN_FILE={0}/vcpkg/scripts/buildsystems/vcpkg.cmake', github.workspace) || '' }}

- name: Build downstream consumer
run: cmake --build ci-consumer/build --config Release
3 changes: 2 additions & 1 deletion cmake/trx-cppConfig.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@

include(CMakeFindDependencyMacro)
find_dependency(Eigen3)
find_dependency(libzip CONFIG)
# mio and json11 are header-only and vendored; no package required
# libzip is a PRIVATE dependency — consumers do not need it
# libzip is a transitive dependency of the static library

include("${CMAKE_CURRENT_LIST_DIR}/trx-cppTargets.cmake")

Expand Down
Loading