Conversation
Add a Windows-specific `CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS` setting in the top-level CMake configuration so shared-library builds on Windows export symbols explicitly. Extend CI with a downstream consumer job that installs `trx-cpp`, runs a minimal `find_package(trx-cpp CONFIG REQUIRED)` build, and verifies the package can be consumed after the main build succeeds. This helps catch Windows packaging/export regressions that a self-build does not surface, while keeping the existing build and test workflow intact.
jhlegarreta
changed the title
jhlegarreta
force-pushed
the
fix/ensure-dependent-windows-compilation
branch
from
August 7, 2026 18:15
21f15de to
4d80d41
Compare
Contributor
Author
|
@mattcieslak @hjmjohnson I confess that my CMake abilities are not at their best, so suggestions are welcome. |
Contributor
Author
|
I know the CI is not working as expected here; will try to have a look at it over the next few days. |
Contributor
Author
|
Re #53 (comment): I see that the failures were addressed in 6913628, so no further action is required. Thanks @frheault for having taken the time to address this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Windows-specific
CMAKE_WINDOWS_EXPORT_ALL_SYMBOLSsetting in the top-level CMake configuration so shared-library builds on Windows export symbols explicitly.Extend CI with a downstream consumer job that installs
trx-cpp, runs a minimalfind_package(trx-cpp CONFIG REQUIRED)build, and verifies the package can be consumed after the main build succeeds.This helps catch Windows packaging/export regressions that a self-build does not surface, while keeping the existing build and test workflow intact.
Fixes #48.