Skip to content

Support unit64 offsets #50

Description

@36000

Currently, if I try to load a trx file using trx-cpp that has offsets larger than int32 max, it segfaults. This PR may be related: #49

With pyAFQ, we sometimes generate tractograms with 100s of millions of streamlines, and here, TRX is super convenient (really the only file format that can handle that many streamlines). These work with trx-python but not trx-cpp. Let me know if you would like me to provide files to reproduce the error. Maybe I am doing something wrong on my end, but I think it's caused by int32 being hardcoded in certain places.

Thank you,
John Kruper

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions