fix(authz): restore default-deny permission filters and fix intersect ordering#97
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
… ordering Restores the authorization fix from Netflix#6155 that was inadvertently reverted: - Restore OrganizationMemberPermission on GET /users/{user_id} endpoint - Use outerjoin in restricted_incident_filter and restricted_case_filter so open incidents/cases without participants remain visible - Apply default-deny: only admin/owner/manager get unrestricted access; all other roles see open items + restricted items where they participate - Apply model-specific filters directly to the query instead of using intersect, which was causing sort ordering to be lost - Remove debug print statement from apply_filter_specific_joins Co-Authored-By: bot_apk <apk@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the authorization hardening from Netflix#6155 that was reverted in e3d93a6. Three interrelated bugs:
restricted_incident_filter/restricted_case_filteronly gated onrole == member(inner join), meaning open items without participants were invisible and non-member/non-admin roles got no restriction at all. Fixed to default-deny withouterjoin:search_filter_sort_paginatestored the restricted query inquery_restrictedthen usedquery.intersect(query_restricted), which destroyed sort ordering. Fixed by applyingapply_model_specific_filtersdirectly toquery.GET /users/{user_id}lost itsOrganizationMemberPermissiondependency — restored.Also removed a stray debug
print()inapply_filter_specific_joins.Link to Devin session: https://app.devin.ai/sessions/da945d8d851d48edbd994540b9e8a8b9