fix(authz): restore default-deny authorization filters and endpoint permissions#93
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
fix(authz): restore default-deny authorization filters and endpoint permissions#93devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…ermissions
- Restore OrganizationMemberPermission on GET /users/{user_id} endpoint
- Fix restricted_incident_filter and restricted_case_filter to use
default-deny approach: admin/owner/manager get unrestricted access,
all other roles see only open items or restricted items where they
are a participant
- Use outerjoin instead of inner join so open items are still returned
for non-admin users without participant records
- Apply model-specific filters directly to query instead of using
intersect with a separate query_restricted variable, which broke
sort ordering
- Remove debug print statement from apply_filter_specific_joins
Co-Authored-By: bot_apk <apk@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the authorization fix from PR Netflix#6155 that was inadvertently reverted. Three bugs were reintroduced:
GET /users/{user_id}endpoint lost itsOrganizationMemberPermissionguard — any unauthenticated caller could fetch user details.restricted_incident_filter/restricted_case_filteronly checkedrole == member— non-admin roles likenonebypassed filtering entirely. The fix restores a default-deny approach:search_filter_sort_paginateusedquery.intersect(query_restricted)— this brokeORDER BYsince SQLINTERSECTdiscards ordering. Fix appliesapply_model_specific_filtersdirectly toquery(no separate variable, no intersect for authz).Also removes a stray
print()inapply_filter_specific_joins.Link to Devin session: https://app.devin.ai/sessions/1587d9d4f5044989beb300fcec6baf10