feat(incident): add optional external_reference_url field#92
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
feat(incident): add optional external_reference_url field#92devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Add external_reference_url (nullable String) to the Incident model, exposed through all Pydantic schemas (Base/Create/Update/Read/ReadMinimal) and included in the service create() constructor. Alembic migration adds the column. Tests cover model persistence, schema serialization, and round-trip update/clear. Co-Authored-By: bot_apk <apk@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
external_reference_url— an optional text field onIncidentfor linking to external systems (e.g. PagerDuty, Jira, third-party trackers).Model:
Incident.external_reference_url = Column(String, nullable=True)Pydantic schemas:
external_reference_url: str | None = Noneadded toIncidentBase(inherited byIncidentCreate,IncidentUpdate), and explicitly toIncidentReadMinimalandIncidentRead.Service:
create()now passesexternal_reference_urlfrom the incoming schema to theIncidentconstructor.update()already picks it up viaincident_in.dict(exclude_unset=True).Migration:
37b4dd1f93b3—ADD COLUMN external_reference_url VARCHAR NULLonincident.Tests: 7 new tests in
tests/incident/test_incident_models.pycovering model persistence, schema defaults, round-trip set/clear, and inclusion in Create/Update schemas.Link to Devin session: https://app.devin.ai/sessions/f18e5306965945bdaa43340f355c14d2